[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_s
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine |
Date: |
Wed, 14 Sep 2016 16:33:30 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 |
On 09/14/2016 03:59 PM, Alex Bennée wrote:
>
> David Gibson <address@hidden> writes:
>
>> From: Cédric Le Goater <address@hidden>
>>
>> The exact same routine will be used in PowerNV.
>>
>> Signed-off-by: Cédric Le Goater <address@hidden>
>> Signed-off-by: David Gibson <address@hidden>
>
> This patch has broken 32 bit x86 builds on CentOS6 (I happened to be looking
> at something else and found it broken):
>
> 14:57 address@hidden/i686 [qemu.git/bisect:???] >make
> CC ppc-softmmu/hw/ppc/fdt.o
> In file included from /home/alex/lsrc/qemu.git/hw/ppc/fdt.c:14:
> /home/alex/lsrc/qemu.git/include/hw/ppc/fdt.h:15: error: redefinition of
> typedef ‘CPUPPCState’
> /home/alex/lsrc/qemu.git/target-ppc/cpu-qom.h:41: note: previous
> declaration of ‘CPUPPCState’ was here
> make[1]: *** [hw/ppc/fdt.o] Error 1
> make: *** [subdir-ppc-softmmu] Error 2
ok. CentOS6 must be 4.4 compiler, which has that kind of problem.
Could you try that quick fix ?
Thanks,
C.
>From 0d0c0ac07ef82c656a8664241bef4f8e834a9b44 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?C=C3=A9dric=20Le=20Goater?= <address@hidden>
Date: Wed, 14 Sep 2016 16:27:26 +0200
Subject: [PATCH] hw/ppc: fix a compile breakage on CentOS 6
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Old versions of gcc, like on CentOS 6, do not support multiple
declarations of the same typedef. Let's remove the extra one in header
file hw/ppc/fdt.h.
Signed-off-by: Cédric Le Goater <address@hidden>
---
include/hw/ppc/fdt.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/hw/ppc/fdt.h b/include/hw/ppc/fdt.h
index 2c68d1616f5c..b58ef616c45c 100644
--- a/include/hw/ppc/fdt.h
+++ b/include/hw/ppc/fdt.h
@@ -12,8 +12,6 @@
#include "qemu/error-report.h"
-typedef struct CPUPPCState CPUPPCState;
-
#define _FDT(exp) \
do { \
int ret = (exp); \
--
2.7.4
- [Qemu-ppc] [PULL 51/64] target-ppc: add extswsli[.] instruction, (continued)
- [Qemu-ppc] [PULL 51/64] target-ppc: add extswsli[.] instruction, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 43/64] ppc: load/store multiple and string insns don't do LE, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 49/64] target-ppc: add vslv instruction, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 24/64] ppc: Make float_check_status() pass the return address, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 28/64] ppc: Don't update NIP in lmw/stmw/icbi, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 59/64] ppc: Improve flags for helpers loading/writing the time facilities, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 22/64] ppc: Rename fload_invalid_op_excp to float_invalid_op_excp, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 63/64] tests: Resort check-qtest entries in Makefile.include, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 54/64] hw/ppc: add a ppc_create_page_sizes_prop() helper routine, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 47/64] target-ppc: add vabsdu[b, h, w] instructions, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 40/64] ppc: Fix CFAR updates, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 52/64] ppc: Rename #include'd .c files to .inc.c, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 20/64] ppc: Move VMX ops out of translate.c, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 18/64] ppc: Move embedded spe ops out of translate.c, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 48/64] target-ppc: add vcmpnez[b, h, w][.] instructions, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 19/64] ppc: Move DFP ops out of translate.c, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 38/64] ppc: Handle unconditional (always/never) traps at translation time, David Gibson, 2016/09/07
- [Qemu-ppc] [PULL 60/64] ppc: Improve the exception helpers flags, David Gibson, 2016/09/07