[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [QEMU PATCH v16 4/4] migration: add error_report
From: |
Dr. David Alan Gilbert |
Subject: |
Re: [Qemu-ppc] [QEMU PATCH v16 4/4] migration: add error_report |
Date: |
Fri, 9 Dec 2016 10:34:31 +0000 |
User-agent: |
Mutt/1.7.1 (2016-10-04) |
* Jianjun Duan (address@hidden) wrote:
> Added error_report where version_ids do not match in vmstate_load_state.
>
> Signed-off-by: Jianjun Duan <address@hidden>
Thanks,
Reviewed-by: Dr. David Alan Gilbert <address@hidden>
> ---
> migration/vmstate.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/migration/vmstate.c b/migration/vmstate.c
> index 2f9d4ba..8ddd230 100644
> --- a/migration/vmstate.c
> +++ b/migration/vmstate.c
> @@ -85,6 +85,9 @@ int vmstate_load_state(QEMUFile *f, const
> VMStateDescription *vmsd,
>
> trace_vmstate_load_state(vmsd->name, version_id);
> if (version_id > vmsd->version_id) {
> + error_report("%s: incoming version_id %d is too new "
> + "for local version_id %d",
> + vmsd->name, version_id, vmsd->version_id);
> trace_vmstate_load_state_end(vmsd->name, "too new", -EINVAL);
> return -EINVAL;
> }
> @@ -95,6 +98,9 @@ int vmstate_load_state(QEMUFile *f, const
> VMStateDescription *vmsd,
> trace_vmstate_load_state_end(vmsd->name, "old path", ret);
> return ret;
> }
> + error_report("%s: incoming version_id %d is too old "
> + "for local minimum version_id %d",
> + vmsd->name, version_id, vmsd->minimum_version_id);
> trace_vmstate_load_state_end(vmsd->name, "too old", -EINVAL);
> return -EINVAL;
> }
> --
> 1.9.1
>
--
Dr. David Alan Gilbert / address@hidden / Manchester, UK