[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 08/24] virt-arm: add node-id property to CPU
From: |
Andrew Jones |
Subject: |
Re: [Qemu-ppc] [PATCH v2 08/24] virt-arm: add node-id property to CPU |
Date: |
Thu, 4 May 2017 11:57:20 +0200 |
User-agent: |
Mutt/1.6.0.1 (2016-04-01) |
On Wed, May 03, 2017 at 02:57:02PM +0200, Igor Mammedov wrote:
> it will allow switching from cpu_index to property based
> numa mapping in follow up patches.
>
> Signed-off-by: Igor Mammedov <address@hidden>
> ---
> hw/arm/virt.c | 15 +++++++++++++++
> target/arm/cpu.c | 1 +
> 2 files changed, 16 insertions(+)
>
> diff --git a/hw/arm/virt.c b/hw/arm/virt.c
> index 3e19b5f..05a2822 100644
> --- a/hw/arm/virt.c
> +++ b/hw/arm/virt.c
> @@ -1350,6 +1350,7 @@ static void machvirt_init(MachineState *machine)
> for (n = 0; n < possible_cpus->len; n++) {
> Object *cpuobj;
> CPUState *cs;
> + int node_id;
>
> if (n >= smp_cpus) {
> break;
> @@ -1362,6 +1363,20 @@ static void machvirt_init(MachineState *machine)
> cs = CPU(cpuobj);
> cs->cpu_index = n;
>
> + node_id = numa_get_node_for_cpu(cs->cpu_index);
> + if (node_id == nb_numa_nodes) {
> + /* by default CPUState::numa_node was 0 if it's not set via CLI
> + * keep it this way for now but in future we probably should
> + * refuse to start up with incomplete numa mapping */
> + node_id = 0;
> + }
> + if (cs->numa_node == CPU_UNSET_NUMA_NODE_ID) {
> + cs->numa_node = node_id;
> + } else {
> + /* CPU isn't device_add compatible yet, this shouldn't happen */
> + error_setg(&error_abort, "user set node-id not implemented");
> + }
> +
> if (!vms->secure) {
> object_property_set_bool(cpuobj, false, "has_el3", NULL);
> }
> diff --git a/target/arm/cpu.c b/target/arm/cpu.c
> index ee1406d..c185eb1 100644
> --- a/target/arm/cpu.c
> +++ b/target/arm/cpu.c
> @@ -1573,6 +1573,7 @@ static Property arm_cpu_properties[] = {
> DEFINE_PROP_UINT32("midr", ARMCPU, midr, 0),
> DEFINE_PROP_UINT64("mp-affinity", ARMCPU,
> mp_affinity, ARM64_AFFINITY_INVALID),
> + DEFINE_PROP_INT32("node-id", CPUState, numa_node,
> CPU_UNSET_NUMA_NODE_ID),
> DEFINE_PROP_END_OF_LIST()
> };
>
> --
> 2.7.4
>
Reviewed-by: Andrew Jones <address@hidden>
- Re: [Qemu-ppc] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards, (continued)
Re: [Qemu-ppc] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards, Eduardo Habkost, 2017/05/03
Re: [Qemu-ppc] [PATCH v2 05/24] numa: move source of default CPUs to NUMA node mapping into boards, Eduardo Habkost, 2017/05/03
[Qemu-ppc] [PATCH v2 07/24] pc: add node-id property to CPU, Igor Mammedov, 2017/05/03
[Qemu-ppc] [PATCH v2 08/24] virt-arm: add node-id property to CPU, Igor Mammedov, 2017/05/03
- Re: [Qemu-ppc] [PATCH v2 08/24] virt-arm: add node-id property to CPU,
Andrew Jones <=
[Qemu-ppc] [PATCH v2 06/24] spapr: add node-id property to sPAPR core, Igor Mammedov, 2017/05/03
[Qemu-ppc] [PATCH v2 09/24] numa: add check that board supports cpu_index to node mapping, Igor Mammedov, 2017/05/03