[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [for-2.11 PATCH 02/26] spapr_pci: use memory_region_add_s
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [for-2.11 PATCH 02/26] spapr_pci: use memory_region_add_subregion() with DMA windows |
Date: |
Wed, 26 Jul 2017 13:56:02 +1000 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Wed, Jul 26, 2017 at 01:33:04PM +1000, Alexey Kardashevskiy wrote:
> On 26/07/17 03:58, Greg Kurz wrote:
> > Passing a null priority to memory_region_add_subregion_overlap() is
> > strictly equivalent to calling memory_region_add_subregion().
> >
> > Signed-off-by: Greg Kurz <address@hidden>
>
> Reviewed-by: Alexey Kardashevskiy <address@hidden>
In fact, this cleanup makes sense on its own. So, I've started a
ppc-for-2.11 branch and applied this to it.
>
> > ---
> > hw/ppc/spapr_pci.c | 4 ++--
> > 1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
> > index 70a99a032267..3fe7f3145467 100644
> > --- a/hw/ppc/spapr_pci.c
> > +++ b/hw/ppc/spapr_pci.c
> > @@ -1752,8 +1752,8 @@ static void spapr_phb_realize(DeviceState *dev, Error
> > **errp)
> > i, sphb->dtbusname);
> > return;
> > }
> > - memory_region_add_subregion_overlap(&sphb->iommu_root, 0,
> > - spapr_tce_get_iommu(tcet), 0);
> > + memory_region_add_subregion(&sphb->iommu_root, 0,
> > + spapr_tce_get_iommu(tcet));
> > }
> >
> > sphb->msi = g_hash_table_new_full(g_int_hash, g_int_equal, g_free,
> > g_free);
> >
> >
>
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature