[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board
From: |
François Revol |
Subject: |
Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board |
Date: |
Fri, 18 Aug 2017 13:24:13 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.2.1 |
Le 18/08/2017 à 08:10, David Gibson a écrit :
> On Sun, Aug 13, 2017 at 07:04:38PM +0200, BALATON Zoltan wrote:
>> Add emulation of aCube Sam460ex board based on AMCC 460EX embedded SoC.
>> This is not a full implementation yet with a lot of components still
>> missing but enough to start a Linux kernel and the U-Boot firmware.
>>
>> Signed-off-by: François Revol <address@hidden>
>> Signed-off-by: BALATON Zoltan <address@hidden>
>
> There are a *lot* of devices defined here. Most of them look like
> they belong to the SoC, not the board (since they use DCRs), so it
> doesn't really make sense to define them in a board file. It would
> also make it easier to review if they were split up into separate
> patches.
>
Indeed, I never thought it would need that many devices to run, and I
intended to move that out but never did.
While it'd make it easier to review, I also recall waiting 3 years to
get a simple patch in just because someone wanted the code to first be
refactored (hint: wacom) :p
François.
signature.asc
Description: OpenPGP digital signature
- Re: [Qemu-ppc] [Qemu-devel] [RFC PATCH 05/12] ppc4xx: Split off 4xx I2C emulation from ppc405_uc to its own file, (continued)
- [Qemu-ppc] [RFC PATCH 07/12] ppc4xx_i2c: Implement basic I2C functions, BALATON Zoltan, 2017/08/13
- [Qemu-ppc] [RFC PATCH 06/12] ppc4xx_i2c: QOMify, BALATON Zoltan, 2017/08/13
- [Qemu-ppc] [RFC PATCH 01/12] ppc4xx: Move MAL from ppc405_uc to ppc4xx_devs, BALATON Zoltan, 2017/08/13
- [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board, BALATON Zoltan, 2017/08/13
- Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board, David Gibson, 2017/08/18
- Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board,
François Revol <=
- Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board, BALATON Zoltan, 2017/08/18
- Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board, David Gibson, 2017/08/21
- Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board, BALATON Zoltan, 2017/08/22
- Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board, David Gibson, 2017/08/22
- Re: [Qemu-ppc] [RFC PATCH 12/12] ppc: Add aCube Sam460ex board, BALATON Zoltan, 2017/08/22