[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 1/4] ppc: change CPUPPCState access_type from int
From: |
Laurent Vivier |
Subject: |
Re: [Qemu-ppc] [PATCH 1/4] ppc: change CPUPPCState access_type from int to uint8_t |
Date: |
Sun, 10 Sep 2017 18:30:25 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.3.0 |
On 10/09/2017 16:37, Mark Cave-Ayland wrote:
> This change was suggested by Alexey in advance of a subsequent commit which
> adds access_type into vmstate_ppc_cpu.
>
> Signed-off-by: Mark Cave-Ayland <address@hidden>
> ---
> target/ppc/cpu.h | 4 ++--
> target/ppc/machine.c | 4 +++-
> 2 files changed, 5 insertions(+), 3 deletions(-)
>
> diff --git a/target/ppc/cpu.h b/target/ppc/cpu.h
> index 12f0949..59d1656 100644
> --- a/target/ppc/cpu.h
> +++ b/target/ppc/cpu.h
> @@ -1010,8 +1010,8 @@ struct CPUPPCState {
> /* Next instruction pointer */
> target_ulong nip;
>
> - int access_type; /* when a memory exception occurs, the access
> - type is stored here */
> + uint8_t access_type; /* when a memory exception occurs, the access
> + type is stored here */
I think this breaks TCG as we have:
target/ppc/translate.c:
82 void ppc_translate_init(void)
...
191
192 cpu_access_type = tcg_global_mem_new_i32(cpu_env,
193 offsetof(CPUPPCState,
access_type), "access_type");
194
195 done_init = 1;
196 }
it expects an int32_t (or int).
Thanks,
Laurent
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 2/4] ppc: add CPU IRQ state to PPC VMStateDescription, (continued)
- [Qemu-ppc] [PATCH 4/4] ppc: ensure we update the decrementer value during migration, Mark Cave-Ayland, 2017/09/10
- Re: [Qemu-ppc] [PATCH 4/4] ppc: ensure we update the decrementer value during migration, David Gibson, 2017/09/13
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration, Mark Cave-Ayland, 2017/09/13
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration, Laurent Vivier, 2017/09/13
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration, David Gibson, 2017/09/13
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration, Mark Cave-Ayland, 2017/09/15
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 4/4] ppc: ensure we update the decrementer value during migration, David Gibson, 2017/09/19
[Qemu-ppc] [PATCH 1/4] ppc: change CPUPPCState access_type from int to uint8_t, Mark Cave-Ayland, 2017/09/10
- Re: [Qemu-ppc] [PATCH 1/4] ppc: change CPUPPCState access_type from int to uint8_t,
Laurent Vivier <=
[Qemu-ppc] [PATCH 3/4] ppc: add CPU access_type into the migration stream, Mark Cave-Ayland, 2017/09/10