[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension() |
Date: |
Fri, 15 Sep 2017 18:39:32 +1000 |
User-agent: |
Mutt/1.8.3 (2017-05-23) |
On Fri, Sep 15, 2017 at 10:18:49AM +0200, Thomas Huth wrote:
> On 15.09.2017 08:35, David Gibson wrote:
> > On Fri, Sep 15, 2017 at 07:15:41AM +0200, Thomas Huth wrote:
> >> On 14.09.2017 21:25, Greg Kurz wrote:
> >>> The following capabilities are VM specific:
> >>> - KVM_CAP_PPC_SMT_POSSIBLE
> >>> - KVM_CAP_PPC_HTAB_FD
> >>
> >> BTW, looks like kvmppc_has_cap_htab_fd() is dead code ... should we
> >> either remove it or check it somewhere?
> >
> > It's checked in kvmppc_get_htab_fd().
>
> That function checks the "cap_htab_fd" variable, but is not using the
> kvmppc_has_cap_htab_fd() function which I was referring to.
Oh, sorry, good point.
We should remove it.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- Re: [Qemu-ppc] [PATCH 1/3] kvm: check KVM_CAP_SYNC_MMU with kvm_vm_check_extension(), (continued)
Re: [Qemu-ppc] [PATCH 3/3] ppc/kvm: check some capabilities with kvm_vm_check_extension(), David Gibson, 2017/09/15