[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v8 09/14] hw/ppc: Replace fprintf(stderr, "*\n" wi
From: |
Thomas Huth |
Subject: |
Re: [Qemu-ppc] [PATCH v8 09/14] hw/ppc: Replace fprintf(stderr, "*\n" with error_report() |
Date: |
Tue, 6 Feb 2018 18:06:22 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 |
On 03.02.2018 09:43, Markus Armbruster wrote:
> From: Alistair Francis <address@hidden>
>
> Replace a large number of the fprintf(stderr, "*\n" calls with
> error_report(). The functions were renamed with these commands and then
> compiler issues where manually fixed.
[...]
> Some lines were then manually tweaked to pass checkpatch and some curly
> braces were added to match QEMU style.
>
> Signed-off-by: Alistair Francis <address@hidden>
> Cc: address@hidden
>
> Conversions that aren't followed by exit() dropped, because they might
> be inappropriate.
>
> Also trim trailing punctuation from error messages.
>
> Signed-off-by: Markus Armbruster <address@hidden>
> Reviewed-by: Philippe Mathieu-Daudé <address@hidden>
> ---
> hw/ppc/e500.c | 16 ++++++++--------
> hw/ppc/mac_newworld.c | 2 +-
> hw/ppc/mac_oldworld.c | 2 +-
> hw/ppc/ppc405_boards.c | 15 ++++++---------
> hw/ppc/ppc440_bamboo.c | 16 ++++++++--------
> hw/ppc/prep.c | 4 ++--
> hw/ppc/virtex_ml507.c | 4 ++--
> 7 files changed, 28 insertions(+), 31 deletions(-)
Reviewed-by: Thomas Huth <address@hidden>