[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v5 27/36] sysbus: add a sysbus_mmio_unmap() helper
From: |
David Gibson |
Subject: |
Re: [Qemu-ppc] [PATCH v5 27/36] sysbus: add a sysbus_mmio_unmap() helper |
Date: |
Tue, 4 Dec 2018 12:59:05 +1100 |
User-agent: |
Mutt/1.10.1 (2018-07-13) |
On Mon, Dec 03, 2018 at 04:52:46PM +0100, Cédric Le Goater wrote:
> On 11/29/18 5:36 PM, Cédric Le Goater wrote:
> > On 11/29/18 5:09 AM, David Gibson wrote:
> >> On Fri, Nov 16, 2018 at 11:57:20AM +0100, Cédric Le Goater wrote:
> >>> This will be used to remove the MMIO regions of the POWER9 XIVE
> >>> interrupt controller when the sPAPR machine is reseted.
> >>>
> >>> Signed-off-by: Cédric Le Goater <address@hidden>
> >>
> >> Reviewed-by: David Gibson <address@hidden>
> >>
> >> Since the code looks sane.
> >>
> >> Hoever, I think using memory_region_set_enabled() would be a better
> >> idea for our purposes than actually adding/deleting the subregion.
> >
> > Yes and we might not need this one anymore.
>
> As we are destroying the KVM device, we also need to remove the mmap
> in QEMU, else we will have a VMA with a page fault handler pointing
> on a bogus KVM device. which means destroying the memory region, so
> we can not use memory_region_set_enabled().
>
> Anyhow mapping/unmapping works well.
Ah, ok.
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature