qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-ppc] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM defi


From: Thomas Huth
Subject: Re: [Qemu-ppc] [PATCH 03/16] hw/devices: Remove unused TC6393XB_RAM definition
Date: Mon, 7 Jan 2019 07:32:07 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1

On 2019-01-04 18:58, Philippe Mathieu-Daudé wrote:
> Introduced in 64b40bc54a9, this definition is no more used since
> a0b753dfd39. Remove it.
> 
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  include/hw/devices.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/include/hw/devices.h b/include/hw/devices.h
> index 0e27feb0c2..4019b3be17 100644
> --- a/include/hw/devices.h
> +++ b/include/hw/devices.h
> @@ -51,7 +51,6 @@ void retu_key_event(void *retu, int state);
>  
>  /* tc6393xb.c */
>  typedef struct TC6393xbState TC6393xbState;
> -#define TC6393XB_RAM 0x110000 /* amount of ram for Video and USB */
>  TC6393xbState *tc6393xb_init(struct MemoryRegion *sysmem,
>                               uint32_t base, qemu_irq irq);
>  void tc6393xb_gpio_out_set(TC6393xbState *s, int line,
> 

I think I'd simply squash this into the next patch and mention it in the
patch description there that you removed the #define.

 Thomas



reply via email to

[Prev in Thread] Current Thread [Next in Thread]