[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH qemu] spapr: Fix fdt warnings
|
From: |
Richard Henderson |
|
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH qemu] spapr: Fix fdt warnings |
|
Date: |
Wed, 16 Jan 2019 17:17:33 +1100 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 1/16/19 3:19 PM, Alexey Kardashevskiy wrote:
> because TARGET_FMT_lx is defined as "%016"PRIx64.
>
> This uses simple "%lx" to suppress the warning. Since it is spapr which
> is always 64bit, we assume here that hwaddr is always "long".
This file is not solely for kvm, i.e. ppc64 hosts. Thus this
is a bad assumption and will fail for a 32-bit host.
You may want to use PRIx64 and assume hwaddr == uint64_t, or
also include an explicit cast to uint64_t.
r~