[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v3] ppc: add host-serial and host-model machine at
From: |
P J P |
Subject: |
Re: [Qemu-ppc] [PATCH v3] ppc: add host-serial and host-model machine attributes |
Date: |
Mon, 18 Feb 2019 23:50:22 +0530 (IST) |
Hello Greg, Dan,
+-- On Mon, 18 Feb 2019, Greg Kurz wrote --+
| >>> + spapr->host_model = NULL;
| >>
| >> This isn't needed since object_initialize_with_type() already takes care
| >> of zeroing the instance for us.
| >>
| >>> + spapr->host_serial = NULL;
| >>
| >> Same here.
|
| Alright then if there's prior consensus on compatibility versus security.
|
| So, with or without the unneeded zeroing of the spapr->host_* fields:
|
| Reviewed-by: Greg Kurz <address@hidden>
I have sent a revised patch v4 removing above NULL initialisations. Thank you
for the review.
Thank you.
--
Prasad J Pandit / Red Hat Product Security Team
47AF CE69 3A90 54AA 9045 1053 DD13 3D32 FE5B 041F