[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH v2 1/3] ppc/pnv: increase kernel size limit to 256
From: |
Cédric Le Goater |
Subject: |
Re: [Qemu-ppc] [PATCH v2 1/3] ppc/pnv: increase kernel size limit to 256MiB |
Date: |
Mon, 25 Feb 2019 19:55:44 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 |
On 2/25/19 6:01 PM, Murilo Opsfelder Araujo wrote:
> Building kernel with CONFIG_DEBUG_INFO_REDUCED can generate a ~90MB image and
> building with CONFIG_DEBUG_INFO can generate a ~225M one, both exceeds the
> current limit of 32MiB.
>
> Increasing kernel size limit to 256MiB should fit for now.
Reviewed-by: Cédric Le Goater <address@hidden>
Thanks,
C.
>
> Signed-off-by: Murilo Opsfelder Araujo <address@hidden>
> ---
> hw/ppc/pnv.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/hw/ppc/pnv.c b/hw/ppc/pnv.c
> index da540860a2..1dbb62c4c9 100644
> --- a/hw/ppc/pnv.c
> +++ b/hw/ppc/pnv.c
> @@ -54,6 +54,7 @@
> #define FW_MAX_SIZE 0x00400000
>
> #define KERNEL_LOAD_ADDR 0x20000000
> +#define KERNEL_MAX_SIZE (256 * MiB)
> #define INITRD_LOAD_ADDR 0x60000000
>
> static const char *pnv_chip_core_typename(const PnvChip *o)
> @@ -588,7 +589,7 @@ static void pnv_init(MachineState *machine)
> long kernel_size;
>
> kernel_size = load_image_targphys(machine->kernel_filename,
> - KERNEL_LOAD_ADDR, 0x2000000);
> + KERNEL_LOAD_ADDR, KERNEL_MAX_SIZE);
> if (kernel_size < 0) {
> error_report("Could not load kernel '%s'",
> machine->kernel_filename);
>