[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 11/11] pflash: Clean up after comm
From: |
Markus Armbruster |
Subject: |
Re: [Qemu-ppc] [Qemu-devel] [PATCH v2 11/11] pflash: Clean up after commit 368a354f02b part 2 |
Date: |
Wed, 27 Feb 2019 07:57:10 +0100 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) |
BALATON Zoltan <address@hidden> writes:
> On Tue, 26 Feb 2019, Markus Armbruster wrote:
>> QOMification left parameter @size unused in pflash_cfi01_register()
>> and pflash_cfi02_register(). Obviously, @size should match
>> @sector_len and @nb_blocs, i.e. size == sector_len * nb_blocs. All
>> callers satisfy this.
>>
>> Remove @nb_blocs and compute it from @size and @sector_len.
>>
>> Signed-off-by: Markus Armbruster <address@hidden>
>> Reviewed-by: Laszlo Ersek <address@hidden>
>> Reviewed-by: Alex Bennée <address@hidden>
>> ---
[...]
>> diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c
>> index 304dbeab2f..2e526218f4 100644
>> --- a/hw/arm/gumstix.c
>> +++ b/hw/arm/gumstix.c
>> @@ -74,7 +74,7 @@ static void connex_init(MachineState *machine)
>> #endif
>> if (!pflash_cfi01_register(0x00000000, "connext.rom", connex_rom,
>> dinfo ? blk_by_legacy_dinfo(dinfo) : NULL,
>> - sector_len, connex_rom / sector_len,
>> + sector_len,
>> 2, 0, 0, 0, 0, be)) {
>
> I'd say you could also reformat and join next line during this change
> to avoid short lines in the middle (also for all other similar changes
> below). But I have no strong feelings about that so I don't
> mind. (This might be easier to review the patch this way but the
> resulting code will look ugly.)
Will do, thanks!
- Re: [Qemu-ppc] [PATCH v2 06/11] sam460ex: Don't size flash memory to match backing image, (continued)
- [Qemu-ppc] [PATCH v2 05/11] hw: Use PFLASH_CFI0{1, 2} and TYPE_PFLASH_CFI0{1, 2}, Markus Armbruster, 2019/02/26
- [Qemu-ppc] [PATCH v2 07/11] ppc405_boards: Don't size flash memory to match backing image, Markus Armbruster, 2019/02/26
- [Qemu-ppc] [PATCH v2 04/11] pflash: Rename *CFI_PFLASH* to *PFLASH_CFI*, Markus Armbruster, 2019/02/26
- [Qemu-ppc] [PATCH v2 08/11] r2d: Flash memory creation is confused about size, mark FIXME, Markus Armbruster, 2019/02/26
- [Qemu-ppc] [PATCH v2 11/11] pflash: Clean up after commit 368a354f02b part 2, Markus Armbruster, 2019/02/26
- [Qemu-ppc] [PATCH v2 10/11] pflash: Clean up after commit 368a354f02b part 1, Markus Armbruster, 2019/02/26
- [Qemu-ppc] [PATCH v2 01/11] pflash: Rename pflash_t to PFlashCFI01, PFlashCFI02, Markus Armbruster, 2019/02/26
- Re: [Qemu-ppc] [PATCH v2 00/11] pflash: Fixes and cleanups, Alex Bennée, 2019/02/26