[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH 9/9] target/ppc: Fix vsum2sws
From: |
Anton Blanchard |
Subject: |
[Qemu-ppc] [PATCH 9/9] target/ppc: Fix vsum2sws |
Date: |
Tue, 7 May 2019 10:48:11 +1000 |
A recent cleanup changed the pre zeroing of the result from 64 bit
to 32 bit operations:
- result.u64[i] = 0;
+ result.VsrW(i) = 0;
This corrupts the result.
Fixes: 60594fea298d ("target/ppc: remove various HOST_WORDS_BIGENDIAN hacks in
int_helper.c")
Signed-off-by: Anton Blanchard <address@hidden>
---
target/ppc/int_helper.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/target/ppc/int_helper.c b/target/ppc/int_helper.c
index 111586c981..b8b3279f71 100644
--- a/target/ppc/int_helper.c
+++ b/target/ppc/int_helper.c
@@ -2038,7 +2038,7 @@ void helper_vsum2sws(CPUPPCState *env, ppc_avr_t *r,
ppc_avr_t *a, ppc_avr_t *b)
for (i = 0; i < ARRAY_SIZE(r->u64); i++) {
int64_t t = (int64_t)b->VsrSW(upper + i * 2);
- result.VsrW(i) = 0;
+ result.VsrD(i) = 0;
for (j = 0; j < ARRAY_SIZE(r->u64); j++) {
t += a->VsrSW(2 * i + j);
}
--
2.20.1
- Re: [Qemu-ppc] [PATCH 6/9] target/ppc: Fix vslv and vsrv, (continued)
- [Qemu-ppc] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Anton Blanchard, 2019/05/06
- Re: [Qemu-ppc] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, David Gibson, 2019/05/07
- [Qemu-ppc] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Anton Blanchard, 2019/05/08
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Mark Cave-Ayland, 2019/05/10
- Re: [Qemu-ppc] [Qemu-devel] [PATCH v2] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, David Gibson, 2019/05/13
- Re: [Qemu-ppc] [Qemu-devel] [PATCH 5/9] target/ppc: Fix xvabs[sd]p, xvnabs[sd]p, xvneg[sd]p, xvcpsgn[sd]p, Mark Cave-Ayland, 2019/05/07
[Qemu-ppc] [PATCH 7/9] target/ppc: Fix vrlwmi and vrlwnm, Anton Blanchard, 2019/05/06
[Qemu-ppc] [PATCH 8/9] target/ppc: Fix dtstsfi and dtstsfiq, Anton Blanchard, 2019/05/06
[Qemu-ppc] [PATCH 9/9] target/ppc: Fix vsum2sws,
Anton Blanchard <=
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Alexey Kardashevskiy, 2019/05/06
Re: [Qemu-ppc] [PATCH 1/9] target/ppc: Fix xvxsigdp, David Gibson, 2019/05/07
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Philippe Mathieu-Daudé, 2019/05/07
Re: [Qemu-ppc] [Qemu-devel] [PATCH 1/9] target/ppc: Fix xvxsigdp, Eric Blake, 2019/05/07