[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PULL 14/44] spapr/xive: EQ page should be naturally aligned
From: |
David Gibson |
Subject: |
[Qemu-ppc] [PULL 14/44] spapr/xive: EQ page should be naturally aligned |
Date: |
Wed, 29 May 2019 16:49:47 +1000 |
From: Cédric Le Goater <address@hidden>
When the OS configures the EQ page in which to receive event
notifications from the XIVE interrupt controller, the page should be
naturally aligned. Add this check.
Signed-off-by: Cédric Le Goater <address@hidden>
Message-Id: <address@hidden>
Reviewed-by: Greg Kurz <address@hidden>
[dwg: Minor change for printf warning on some platforms]
Signed-off-by: David Gibson <address@hidden>
---
hw/intc/spapr_xive.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/hw/intc/spapr_xive.c b/hw/intc/spapr_xive.c
index 097f88d460..33da1a52c6 100644
--- a/hw/intc/spapr_xive.c
+++ b/hw/intc/spapr_xive.c
@@ -993,6 +993,12 @@ static target_ulong h_int_set_queue_config(PowerPCCPU *cpu,
case 16:
case 21:
case 24:
+ if (!QEMU_IS_ALIGNED(qpage, 1ul << qsize)) {
+ qemu_log_mask(LOG_GUEST_ERROR, "XIVE: EQ @0x%" HWADDR_PRIx
+ " is not naturally aligned with %" HWADDR_PRIx "\n",
+ qpage, (hwaddr)1 << qsize);
+ return H_P4;
+ }
end.w2 = cpu_to_be32((qpage >> 32) & 0x0fffffff);
end.w3 = cpu_to_be32(qpage & 0xffffffff);
end.w0 |= cpu_to_be32(END_W0_ENQUEUE);
--
2.21.0
- [Qemu-ppc] [PULL 00/44] ppc-for-4.1 queue 20190529, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 01/44] tests: Fix up docker cross builds for ppc64 (BE) targets, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 03/44] configure: Use quotes around uses of $CPU_CFLAGS, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 02/44] configure: Distinguish ppc64 and ppc64le hosts, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 05/44] hw/ppc/prep: use TYPE_MC146818_RTC instead of a hardcoded string, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 08/44] target/ppc: Add ibm, purr and ibm, spurr device-tree properties, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 04/44] target/ppc/kvm: Fix trace typo, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 10/44] target/ppc: Fix xxbrq, xxbrw, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 14/44] spapr/xive: EQ page should be naturally aligned,
David Gibson <=
- [Qemu-ppc] [PULL 13/44] target/ppc: Fix xxspltib, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 15/44] spapr/xive: fix EQ page addresses above 64GB, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 07/44] hw/ppc/40p: use 1900 as a base year, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 06/44] hw/ppc/40p: Move the MC146818 RTC to the board where it belongs, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 12/44] target/ppc: Fix vsum2sws, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 09/44] target/ppc: Fix xvxsigdp, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 11/44] target/ppc: Fix vslv and vsrv, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 16/44] spapr/xive: print out the EQ page address in the monitor, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 26/44] spapr/xive: add KVM support, David Gibson, 2019/05/29
- [Qemu-ppc] [PULL 17/44] Fix typo on "info pic" monitor cmd output for xive, David Gibson, 2019/05/29