[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Qemu-ppc] [PATCH v3 27/33] hw/ide/microdrive.c: remove device_legacy_re
From: |
Damien Hedde |
Subject: |
[Qemu-ppc] [PATCH v3 27/33] hw/ide/microdrive.c: remove device_legacy_reset calls |
Date: |
Mon, 29 Jul 2019 16:56:48 +0200 |
Replace MicroDriveState legacy reset by device_reset_warm.
The new function propagates also the reset to the sub-buses tree.
The MicroDriveState has a child bus so it is now reset automatically
as well as all the qdev sub tree. It seems to me that IDE_BUS and
IDE_DEVICEs reset methods are not implemented so resetting the
qdev/qbus ide tree will have no effect.
Keep the explicit call to ide_bus_reset (in md_reset function) since
it is not called when using the standard reset method of the IDE_BUS
object.
Signed-off-by: Damien Hedde <address@hidden>
---
hw/ide/microdrive.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/ide/microdrive.c b/hw/ide/microdrive.c
index fc346f5ad5..afe2342da8 100644
--- a/hw/ide/microdrive.c
+++ b/hw/ide/microdrive.c
@@ -173,7 +173,7 @@ static void md_attr_write(PCMCIACardState *card, uint32_t
at, uint8_t value)
case 0x00: /* Configuration Option Register */
s->opt = value & 0xcf;
if (value & OPT_SRESET) {
- device_legacy_reset(DEVICE(s));
+ device_reset_warm(DEVICE(s));
}
md_interrupt_update(s);
break;
@@ -316,7 +316,7 @@ static void md_common_write(PCMCIACardState *card, uint32_t
at, uint16_t value)
case 0xe: /* Device Control */
s->ctrl = value;
if (value & CTRL_SRST) {
- device_legacy_reset(DEVICE(s));
+ device_reset_warm(DEVICE(s));
}
md_interrupt_update(s);
break;
@@ -541,7 +541,7 @@ static int dscm1xxxx_attach(PCMCIACardState *card)
md->attr_base = pcc->cis[0x74] | (pcc->cis[0x76] << 8);
md->io_base = 0x0;
- device_legacy_reset(DEVICE(md));
+ device_reset_warm(DEVICE(md));
md_interrupt_update(md);
return 0;
@@ -551,7 +551,7 @@ static int dscm1xxxx_detach(PCMCIACardState *card)
{
MicroDriveState *md = MICRODRIVE(card);
- device_legacy_reset(DEVICE(md));
+ device_reset_warm(DEVICE(md));
return 0;
}
--
2.22.0
- [Qemu-ppc] [PATCH v3 03/33] Replace all call to device_reset by call to device_legacy_reset, (continued)
- [Qemu-ppc] [PATCH v3 03/33] Replace all call to device_reset by call to device_legacy_reset, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 12/33] hw/pci/: remove qdev/qbus_reset_all call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 18/33] hw/audio/intel-hda.c: remove device_legacy_reset call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 16/33] hw/input/adb.c: remove qdev_reset_all call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 14/33] hw/s390x/s390-virtio-ccw.c: remove qdev_reset_all call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 19/33] hw/sd/pl181.c & omap_mmc.c: remove device_legacy_reset call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 25/33] hw/i386/pc.c: remove device_legacy_reset call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 23/33] hw/scsi/vmw_pvscsi.c: remove device_legacy_reset call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 22/33] hw/ppc/pnv_psi.c: remove device_legacy_reset call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 13/33] hw/scsi/: remove qdev/qbus_reset_all call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 27/33] hw/ide/microdrive.c: remove device_legacy_reset calls,
Damien Hedde <=
- [Qemu-ppc] [PATCH v3 20/33] hw/hyperv/hyperv.c: remove device_legacy_reset call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 31/33] Convert zynq's slcr to 3-phases reset, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 24/33] hw/ppc/spapr: remove device_legacy_reset call, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 28/33] qdev: Remove unused deprecated reset functions, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 29/33] hw/misc/zynq_slcr: use standard register definition, Damien Hedde, 2019/07/29
- [Qemu-ppc] [PATCH v3 32/33] Add uart reset support in zynq_slcr, Damien Hedde, 2019/07/29
- Re: [Qemu-ppc] [PATCH v3 00/33] Multi-phase reset mechanism, Cornelia Huck, 2019/07/30