[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-ppc] [PATCH] spapr/xive: Mask the EAS when allocating an IRQ
From: |
Peter Maydell |
Subject: |
Re: [Qemu-ppc] [PATCH] spapr/xive: Mask the EAS when allocating an IRQ |
Date: |
Tue, 13 Aug 2019 17:46:04 +0100 |
On Tue, 13 Aug 2019 at 17:44, Cédric Le Goater <address@hidden> wrote:
>
> If an IRQ is allocated and not configured, such as a MSI requested by
> a PCI driver, it can be saved in its default state and possibly later
> on restored using the same state. If not initially MASKED, KVM will
> try to find a matching priority/target tuple for the interrupt and
> fail to restore the VM because 0/0 is not a valid target.
>
> When allocating a IRQ number, the EAS should be set to a sane default :
> VALID and MASKED.
>
> Reported-by: Satheesh Rajendran <address@hidden>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
>
> David, this fixes a "virsh save/restore" issue in certain configurations
> of CPU topology which never showed up before :/
>
> Peter, I was busy on a KVM/passthru issue and lacked the time to
> investigate all ... you decide.
rc5 has been tagged so this is definitely too late for 4.1.
thanks
-- PMM