[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 01/34] xics: Minor fixes for XICSFabric interface
From: |
David Gibson |
Subject: |
Re: [PATCH v3 01/34] xics: Minor fixes for XICSFabric interface |
Date: |
Wed, 2 Oct 2019 15:55:51 +1000 |
User-agent: |
Mutt/1.12.1 (2019-06-15) |
On Wed, Oct 02, 2019 at 07:51:45AM +0200, Cédric Le Goater wrote:
> On 02/10/2019 04:51, David Gibson wrote:
> > Interface instances should never be directly dereferenced. So, the common
> > practice is to make them incomplete types to make sure no-one does that.
> > XICSFrabric, however, had a dummy type which is less safe.
> >
> > We were also using OBJECT_CHECK() where we should have been using
> > INTERFACE_CHECK().
> >
> > Signed-off-by: David Gibson <address@hidden>
> > Reviewed-by: Greg Kurz <address@hidden>
>
> Reviewed-by: Greg Kurz <address@hidden>
Uhhh... you sent me an R-b line for Greg, not yourself...
>
> > ---
> > include/hw/ppc/xics.h | 6 +-----
> > 1 file changed, 1 insertion(+), 5 deletions(-)
> >
> > diff --git a/include/hw/ppc/xics.h b/include/hw/ppc/xics.h
> > index 64a2c8862a..faa33ae943 100644
> > --- a/include/hw/ppc/xics.h
> > +++ b/include/hw/ppc/xics.h
> > @@ -147,13 +147,9 @@ struct ICSIRQState {
> > uint8_t flags;
> > };
> >
> > -struct XICSFabric {
> > - Object parent;
> > -};
> > -
> > #define TYPE_XICS_FABRIC "xics-fabric"
> > #define XICS_FABRIC(obj) \
> > - OBJECT_CHECK(XICSFabric, (obj), TYPE_XICS_FABRIC)
> > + INTERFACE_CHECK(XICSFabric, (obj), TYPE_XICS_FABRIC)
> > #define XICS_FABRIC_CLASS(klass) \
> > OBJECT_CLASS_CHECK(XICSFabricClass, (klass), TYPE_XICS_FABRIC)
> > #define XICS_FABRIC_GET_CLASS(obj) \
> >
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v3 00/34] spapr: IRQ subsystem cleanup, David Gibson, 2019/10/01
- [PATCH v3 04/34] xics: Eliminate reset hook, David Gibson, 2019/10/01
- [PATCH v3 02/34] xics: Eliminate 'reject', 'resend' and 'eoi' class hooks, David Gibson, 2019/10/01
- [PATCH v3 07/34] spapr: Fold spapr_phb_lsi_qirq() into its single caller, David Gibson, 2019/10/01
- [PATCH v3 06/34] xics: Create sPAPR specific ICS subtype, David Gibson, 2019/10/01
- [PATCH v3 21/34] spapr, xics, xive: Introduce SpaprInterruptController QOM interface, David Gibson, 2019/10/01
- [PATCH v3 23/34] spapr, xics, xive: Move irq claim and free from SpaprIrq to SpaprInterruptController, David Gibson, 2019/10/01