[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH] xics: Make some device types not user creatable
From: |
Greg Kurz |
Subject: |
[PATCH] xics: Make some device types not user creatable |
Date: |
Fri, 04 Oct 2019 10:37:47 +0200 |
User-agent: |
StGit/unknown-version |
Some device types of the XICS model are exposed to the QEMU command
line:
$ ppc64-softmmu/qemu-system-ppc64 -device help | grep ic[sp]
name "icp"
name "ics"
name "ics-spapr"
name "pnv-icp", desc "PowerNV ICP"
These are internal devices that shouldn't be instantiable by the
user. By the way, they can't be because their respective realize
functions expect link properties that can't be set from the command
line:
qemu-system-ppc64: -device icp: required link 'xics' not found:
Property '.xics' not found
qemu-system-ppc64: -device ics: required link 'xics' not found:
Property '.xics' not found
qemu-system-ppc64: -device ics-spapr: required link 'xics' not found:
Property '.xics' not found
qemu-system-ppc64: -device pnv-icp: required link 'xics' not found:
Property '.xics' not found
Hide them by setting dc->user_creatable to false in the base class
"icp" and "ics" init functions.
Signed-off-by: Greg Kurz <address@hidden>
---
hw/intc/xics.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/hw/intc/xics.c b/hw/intc/xics.c
index dfe7dbd254ab..8d41df3103f9 100644
--- a/hw/intc/xics.c
+++ b/hw/intc/xics.c
@@ -369,6 +369,7 @@ static void icp_class_init(ObjectClass *klass, void *data)
dc->realize = icp_realize;
dc->unrealize = icp_unrealize;
+ dc->user_creatable = false;
}
static const TypeInfo icp_info = {
@@ -689,6 +690,7 @@ static void ics_class_init(ObjectClass *klass, void *data)
dc->props = ics_properties;
dc->reset = ics_reset;
dc->vmsd = &vmstate_ics;
+ dc->user_creatable = false;
}
static const TypeInfo ics_info = {
- [PATCH] xics: Make some device types not user creatable,
Greg Kurz <=