[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 5/7] target/ppc: Add privileged message send facilities
From: |
Cédric Le Goater |
Subject: |
Re: [PATCH 5/7] target/ppc: Add privileged message send facilities |
Date: |
Thu, 9 Jan 2020 08:13:38 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 |
>>>> void helper_book3s_msgclr(CPUPPCState *env, target_ulong rb)
>>>> {
>>>> - int irq = book3s_dbell2irq(rb);
>>>> + int irq = book3s_dbell2irq(rb, 1);
>>>
>>> true/false are preferred to 0/1 for bool types.
>>
>> yes or a define ?
>
> Sorry, I don't understand the question. The second argument to
> book3s_dbell2irq() is a 'bool' type, so the parameter should be 'true'
> rather than '1'.
Yes. I was thinking of adding defines for the 'true' and 'false' value
to clarify what the parameter is doing. But it does not seem really
useful now.
Thanks,
C.