[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[RFC for-5.1 3/4] spapr: Fix failure path for attempting to hot unplug P
From: |
David Gibson |
Subject: |
[RFC for-5.1 3/4] spapr: Fix failure path for attempting to hot unplug PCI bridges |
Date: |
Thu, 26 Mar 2020 16:40:08 +1100 |
For various technical reasons we can't currently allow unplug a PCI to PCI
bridge on the pseries machine. spapr_pci_unplug_request() correctly
generates an error message if that's attempted.
But.. if the given errp is not error_abort or error_fatal, it doesn't
actually stop trying to unplug the bridge anyway.
Signed-off-by: David Gibson <address@hidden>
---
hw/ppc/spapr_pci.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/ppc/spapr_pci.c b/hw/ppc/spapr_pci.c
index 709a52780d..55ca9dee1e 100644
--- a/hw/ppc/spapr_pci.c
+++ b/hw/ppc/spapr_pci.c
@@ -1663,6 +1663,7 @@ static void spapr_pci_unplug_request(HotplugHandler
*plug_handler,
if (pc->is_bridge) {
error_setg(errp, "PCI: Hot unplug of PCI bridges not supported");
+ return;
}
/* ensure any other present functions are pending unplug */
--
2.25.1