[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/19] audio: deprecate -soundhw pcspk
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v3 11/19] audio: deprecate -soundhw pcspk |
Date: |
Mon, 22 Jun 2020 15:07:50 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0 |
On 6/22/20 2:59 PM, Thomas Huth wrote:
> On 22/06/2020 13.29, Gerd Hoffmann wrote:
>> Add deprecation message to the audio init function.
>>
>> Factor out audio initialization and call that from
>> both audio init and realize, so setting audiodev via
>> -global is enough to properly initialize pcspk.
>>
>> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
>> ---
>> hw/audio/pcspk.c | 24 +++++++++++++++++++++---
>> 1 file changed, 21 insertions(+), 3 deletions(-)
> [...]
>> +static int pcspk_audio_init_soundhw(ISABus *bus)
>> +{
>> + PCSpkState *s = pcspk_state;
>> +
>> + warn_report("'-soundhw pcspk' is deprecated, "
>> + "please set a backend using '-global
>> isa-pcspk.audiodev=<name>' instead");
Markus's "Crazy shit around -global (pardon my french)"
series instead suggest to use '-device ...':
https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg06667.html
Could that work here?
>> + return pcspk_audio_init(s);
>> +}
>
> While "-soundhw pcspk" is quite easy to use for the average user, I
> think the "-global" options will be quite hard to figure out, especially
> once this deprecation message got removed again when -soundhw has been
> deleted. Could you maybe add a description how to configure the
> pc-speaker to docs/system/target-i386-desc.rst.inc, too?
>
> Thanks,
> Thomas
>
>
- [PATCH v3 03/19] audio: add deprecated_register_soundhw, (continued)
- [PATCH v3 03/19] audio: add deprecated_register_soundhw, Gerd Hoffmann, 2020/06/22
- [PATCH v3 10/19] audio: deprecate -soundhw hda, Gerd Hoffmann, 2020/06/22
- [PATCH v3 16/19] softmmu: initialize spice and audio earlier, Gerd Hoffmann, 2020/06/22
- [PATCH v3 17/19] audio: rework pcspk_init(), Gerd Hoffmann, 2020/06/22
- [PATCH v3 15/19] pc_basic_device_init: drop no_vmport arg, Gerd Hoffmann, 2020/06/22
- [PATCH v3 14/19] pc_basic_device_init: drop has_pit arg, Gerd Hoffmann, 2020/06/22
- [PATCH v3 13/19] pc_basic_device_init: pass PCMachineState, Gerd Hoffmann, 2020/06/22
- [PATCH v3 18/19] audio: create pcspk device early, add audiodev alias., Gerd Hoffmann, 2020/06/22
- [PATCH v3 11/19] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/06/22
- Re: [PATCH v3 11/19] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/06/22
[PATCH v3 12/19] audio: add soundhw deprecation notice, Gerd Hoffmann, 2020/06/22
[PATCH v3 19/19] audio: set default value for pcspk.iobase property, Gerd Hoffmann, 2020/06/22
[PATCH v3 06/19] audio: deprecate -soundhw adlib, Gerd Hoffmann, 2020/06/22