[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v5 12/20] pc_basic_device_init: drop has_pit arg
From: |
Gerd Hoffmann |
Subject: |
[PATCH v5 12/20] pc_basic_device_init: drop has_pit arg |
Date: |
Thu, 2 Jul 2020 15:25:17 +0200 |
Now that we pass pcms anyway, we don't need the has_pit arg any more.
No functional change.
Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
---
include/hw/i386/pc.h | 1 -
hw/i386/pc.c | 3 +--
hw/i386/pc_piix.c | 2 +-
hw/i386/pc_q35.c | 2 +-
4 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/include/hw/i386/pc.h b/include/hw/i386/pc.h
index 3a601dbe71da..bd447e380b5e 100644
--- a/include/hw/i386/pc.h
+++ b/include/hw/i386/pc.h
@@ -165,7 +165,6 @@ void pc_basic_device_init(struct PCMachineState *pcms,
ISADevice **rtc_state,
bool create_fdctrl,
bool no_vmport,
- bool has_pit,
uint32_t hpet_irqs);
void pc_init_ne2k_isa(ISABus *bus, NICInfo *nd);
void pc_cmos_init(PCMachineState *pcms,
diff --git a/hw/i386/pc.c b/hw/i386/pc.c
index d89e577f6fa1..9f5153b6f24d 100644
--- a/hw/i386/pc.c
+++ b/hw/i386/pc.c
@@ -1160,7 +1160,6 @@ void pc_basic_device_init(struct PCMachineState *pcms,
ISADevice **rtc_state,
bool create_fdctrl,
bool no_vmport,
- bool has_pit,
uint32_t hpet_irqs)
{
int i;
@@ -1211,7 +1210,7 @@ void pc_basic_device_init(struct PCMachineState *pcms,
qemu_register_boot_set(pc_boot_set, *rtc_state);
- if (!xen_enabled() && has_pit) {
+ if (!xen_enabled() && pcms->pit_enabled) {
if (kvm_pit_in_kernel()) {
pit = kvm_pit_init(isa_bus, 0x40);
} else {
diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_piix.c
index a3b416507286..6c1612d0ca45 100644
--- a/hw/i386/pc_piix.c
+++ b/hw/i386/pc_piix.c
@@ -236,7 +236,7 @@ static void pc_init1(MachineState *machine,
/* init basic PC hardware */
pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, true,
- (pcms->vmport != ON_OFF_AUTO_ON), pcms->pit_enabled,
+ (pcms->vmport != ON_OFF_AUTO_ON),
0x4);
pc_nic_init(pcmc, isa_bus, pci_bus);
diff --git a/hw/i386/pc_q35.c b/hw/i386/pc_q35.c
index b16e22c6cccd..6faf4458549a 100644
--- a/hw/i386/pc_q35.c
+++ b/hw/i386/pc_q35.c
@@ -276,7 +276,7 @@ static void pc_q35_init(MachineState *machine)
/* init basic PC hardware */
pc_basic_device_init(pcms, isa_bus, x86ms->gsi, &rtc_state, !mc->no_floppy,
- (pcms->vmport != ON_OFF_AUTO_ON), pcms->pit_enabled,
+ (pcms->vmport != ON_OFF_AUTO_ON),
0xff0104);
/* connect pm stuff to lpc */
--
2.18.4
- [PATCH v5 00/20] audio: deprecate -soundhw, Gerd Hoffmann, 2020/07/02
- [PATCH v5 01/20] stubs: add isa_create_simple, Gerd Hoffmann, 2020/07/02
- [PATCH v5 08/20] audio: deprecate -soundhw gus, Gerd Hoffmann, 2020/07/02
- [PATCH v5 02/20] stubs: add pci_create_simple, Gerd Hoffmann, 2020/07/02
- [PATCH v5 16/20] audio: create pcspk device early, Gerd Hoffmann, 2020/07/02
- [PATCH v5 13/20] pc_basic_device_init: drop no_vmport arg, Gerd Hoffmann, 2020/07/02
- [PATCH v5 17/20] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/07/02
- [PATCH v5 14/20] softmmu: initialize spice and audio earlier, Gerd Hoffmann, 2020/07/02
- [PATCH v5 12/20] pc_basic_device_init: drop has_pit arg,
Gerd Hoffmann <=
- [PATCH v5 03/20] audio: add deprecated_register_soundhw, Gerd Hoffmann, 2020/07/02
- [PATCH v5 07/20] audio: deprecate -soundhw cs4231a, Gerd Hoffmann, 2020/07/02
- [PATCH v5 20/20] audio: set default value for pcspk.iobase property, Gerd Hoffmann, 2020/07/02
- [PATCH v5 19/20] pcspk: update docs/system/target-i386-desc.rst.inc, Gerd Hoffmann, 2020/07/02
- [PATCH v5 09/20] audio: deprecate -soundhw sb16, Gerd Hoffmann, 2020/07/02
- [PATCH v5 18/20] audio: add soundhw deprecation notice, Gerd Hoffmann, 2020/07/02
- [PATCH v5 11/20] pc_basic_device_init: pass PCMachineState, Gerd Hoffmann, 2020/07/02
- [PATCH v5 05/20] audio: deprecate -soundhw es1370, Gerd Hoffmann, 2020/07/02
- [PATCH v5 10/20] audio: deprecate -soundhw hda, Gerd Hoffmann, 2020/07/02