[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 01/11] hw/arm/aspeed: Do not directly map ram container on
From: |
Philippe Mathieu-Daudé |
Subject: |
Re: [PATCH v2 01/11] hw/arm/aspeed: Do not directly map ram container onto main address bus |
Date: |
Wed, 21 Apr 2021 15:02:35 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 4/21/21 7:53 AM, Cédric Le Goater wrote:
> On 4/20/21 8:28 PM, Peter Xu wrote:
>> On Sat, Apr 17, 2021 at 12:30:18PM +0200, Philippe Mathieu-Daudé wrote:
>>> The RAM container is exposed as an AddressSpace.
>>
>> I didn't see where did ram_container got exposed as an address space.
I guess I used the wrong base to git-publish and skipped the first patch =)
>> I see it's added as one subregion of get_system_memory(), which looks okay?
> my version of this patch took a simpler approach. See below.
>
> Thanks,
>
> C.
>
> --- a/hw/arm/aspeed.c
> +++ b/hw/arm/aspeed.c
> @@ -327,7 +327,7 @@ static void aspeed_machine_init(MachineState *machine)
> object_property_set_int(OBJECT(&bmc->soc), "num-cs", amc->num_cs,
> &error_abort);
> object_property_set_link(OBJECT(&bmc->soc), "dram",
> - OBJECT(&bmc->ram_container), &error_abort);
> + OBJECT(machine->ram), &error_abort);
This will work as long as no board maps the main memory elsewhere than
0x0. Using the alias make it more robust (and also is good API example
for the usual "use API via copy/pasting" style when adding new board)
IMHO.
> if (machine->kernel_filename) {
> /*
> * When booting with a -kernel command line there is no u-boot
>
>
- [PATCH v2 00/11] memory: Forbid mapping AddressSpace root MemoryRegion, Philippe Mathieu-Daudé, 2021/04/17
- [PATCH v2 02/11] hw/aspeed/smc: Use the RAM memory region for DMAs, Philippe Mathieu-Daudé, 2021/04/17
- [PATCH v2 03/11] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias, Philippe Mathieu-Daudé, 2021/04/17
- [PATCH v2 04/11] hw/pci-host: Rename Raven ASIC PCI bridge as raven.c, Philippe Mathieu-Daudé, 2021/04/17
- [PATCH v2 05/11] hw/pci-host/raven: Add PCI_IO_BASE_ADDR definition, Philippe Mathieu-Daudé, 2021/04/17
- [PATCH v2 06/11] hw/pci-host/raven: Assert PCI I/O AddressSpace is based at 0x80000000, Philippe Mathieu-Daudé, 2021/04/17
- [PATCH v2 07/11] hw/pci-host/raven: Use MR alias for AS root, not sysbus mapped MR, Philippe Mathieu-Daudé, 2021/04/17
- [RFC PATCH v2 08/11] hw/pci-host/raven: Remove pointless alias mapping onto system bus, Philippe Mathieu-Daudé, 2021/04/17