[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 6/9] target/ppc: moved ppc_cpu_do_interrupt to cpu.c
From: |
Richard Henderson |
Subject: |
Re: [PATCH v3 6/9] target/ppc: moved ppc_cpu_do_interrupt to cpu.c |
Date: |
Mon, 24 May 2021 19:11:02 -0700 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1 |
On 5/21/21 1:17 PM, Bruno Larsen (billionai) wrote:
Moved the ppc_cpu_do_interrupt function to cpu.c file, where it makes
more sense, and turned powerpc_excp not static, as it now needs to be
accessed from outside of excp_helper.c
Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
---
target/ppc/cpu.c | 20 ++++++++++++++++++++
target/ppc/cpu.h | 1 +
target/ppc/excp_helper.c | 19 +------------------
3 files changed, 22 insertions(+), 18 deletions(-)
I don't see what this buys you really.
It's not special-register access, like the rest of cpu.c so far.
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index f4f15279eb..80bb6e70e9 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -38,15 +38,6 @@
/*****************************************************************************/
/* Exception processing */
#if defined(CONFIG_USER_ONLY)
-void ppc_cpu_do_interrupt(CPUState *cs)
-{
- PowerPCCPU *cpu = POWERPC_CPU(cs);
- CPUPPCState *env = &cpu->env;
-
- cs->exception_index = POWERPC_EXCP_NONE;
- env->error_code = 0;
-}
-
This part could move to user_only_helper.c easily.
@@ -324,7 +315,7 @@ static inline void powerpc_set_excp_state(PowerPCCPU *cpu,
* Note that this function should be greatly optimized when called
* with a constant excp, from ppc_hw_interrupt
*/
-static inline void powerpc_excp(PowerPCCPU *cpu, int excp_model, int excp)
+inline void powerpc_excp(PowerPCCPU *cpu, int excp_model, int excp)
Exporting powerpc_excp from this file is not an improvement, as far as I can
see.
r~
- [PATCH v3 3/9] target/ppc: reduce usage of fpscr_set_rounding_mode, (continued)
- [PATCH v3 3/9] target/ppc: reduce usage of fpscr_set_rounding_mode, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 4/9] target/ppc: overhauled and moved logic of storing fpscr, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 5/9] target/ppc: removed unnecessary inclusion of helper-proto.h, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 6/9] target/ppc: moved ppc_cpu_do_interrupt to cpu.c, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 7/9] target/ppc: Added options to disable many TCG-only functions, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 8/9] target/ppc: created tcg-stub.c file, Bruno Larsen (billionai), 2021/05/21
- [PATCH v3 9/9] target/ppc: updated meson.build to support disable-tcg, Bruno Larsen (billionai), 2021/05/21