[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v4 2/5] target/ppc: used ternary operator when registering MA
From: |
David Gibson |
Subject: |
Re: [PATCH v4 2/5] target/ppc: used ternary operator when registering MAS |
Date: |
Tue, 25 May 2021 15:10:02 +1000 |
On Mon, May 24, 2021 at 10:32:18AM -0700, Richard Henderson wrote:
> On 5/24/21 6:59 AM, Bruno Larsen (billionai) wrote:
> > The write calback decision when registering the MAS SPR has been turned
> > into a ternary operation, rather than an if-then-else block.
> >
> > Signed-off-by: Bruno Larsen (billionai)<bruno.larsen@eldorado.org.br>
> > Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> > ---
> > target/ppc/cpu_init.c | 9 +++------
> > 1 file changed, 3 insertions(+), 6 deletions(-)
>
> The commit message here says what, but it doesn't say why.
Right, and "why" is generally the more important thing to be in a
commit message.
> The important part of the change is making the references to
> spr_write_generic* conditional, via SYS_ARG(), so that the code compiles out
> for !CONFIG_TCG.
>
> The actual code change is fine:
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
>
>
> r~
>
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH v4 0/5] target/ppc: add support to disable-tcg, Bruno Larsen (billionai), 2021/05/24
- [PATCH v4 1/5] target/ppc: moved ppc_cpu_do_interrupt to cpu.c, Bruno Larsen (billionai), 2021/05/24
- [PATCH v4 2/5] target/ppc: used ternary operator when registering MAS, Bruno Larsen (billionai), 2021/05/24
- [PATCH v4 3/5] target/ppc: added ifdefs around TCG-only code, Bruno Larsen (billionai), 2021/05/24
- [PATCH v4 4/5] target/ppc: created tcg-stub.c file, Bruno Larsen (billionai), 2021/05/24
- [PATCH v4 5/5] target/ppc: updated meson.build to support disable-tcg, Bruno Larsen (billionai), 2021/05/24