[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/16] Acceptance Tests: add standard clean up at test tearDo
From: |
Willian Rampazzo |
Subject: |
Re: [PATCH 05/16] Acceptance Tests: add standard clean up at test tearDown() |
Date: |
Fri, 24 Sep 2021 16:38:00 -0300 |
Hi, Cleber,
On Fri, Sep 24, 2021 at 3:57 PM Cleber Rosa <crosa@redhat.com> wrote:
>
> The avocado.Test class, used as the basis of the avocado_qemu.Test
> class, performs a clean of temporary directories up as part of its own
> tearDown() implementation.
>
> But the avocado_qemu.Test class is currently missing the same clean
> up, as it implemented its own tearDown() method without resorting to
> the upper class behavior.
>
> This brings avocado_qemu.Test behavior in sync with the standard
> avocado.Test behavior and prevents temporary directories from
> cluttering the test results directory (unless instructed to do so with
> Avocado's "--keep-tmp" option).
>
> Reported-by: Peter Maydell <peter.maydell@linaro.org>
> Signed-off-by: Cleber Rosa <crosa@redhat.com>
> ---
> tests/acceptance/avocado_qemu/__init__.py | 1 +
> 1 file changed, 1 insertion(+)
>
There was a comment from Wainer in the original patch and as you were
on vacation I submitted a respin last Monday:
https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05117.html
I also did some refactoring/fixes to the avocado_qemu here:
https://lists.gnu.org/archive/html/qemu-devel/2021-09/msg05212.html
- [PATCH 00/16] Acceptance Tests: use Avocado 91.0 features and other improvements, Cleber Rosa, 2021/09/24
- [PATCH 01/16] Acceptance Tests: bump Avocado requirement to 91.0, Cleber Rosa, 2021/09/24
- [PATCH 05/16] Acceptance Tests: add standard clean up at test tearDown(), Cleber Rosa, 2021/09/24
- Re: [PATCH 05/16] Acceptance Tests: add standard clean up at test tearDown(),
Willian Rampazzo <=
- [PATCH 06/16] Acceptance Tests: use extract from package from avocado.utils, Cleber Rosa, 2021/09/24
- [PATCH 07/16] Acceptance Tests: workaround expired mipsdistros.mips.com HTTPS cert, Cleber Rosa, 2021/09/24
- [PATCH 08/16] acceptance/tests/vnc.py: use explicit syntax for enabling passwords, Cleber Rosa, 2021/09/24
- [PATCH 09/16] tests/acceptance/boot_xen.py: merge base classes, Cleber Rosa, 2021/09/24
- [PATCH 03/16] Acceptance Tests: add mechanism for listing tests, Cleber Rosa, 2021/09/24
- [PATCH 10/16] tests/acceptance/boot_xen.py: unify tags, Cleber Rosa, 2021/09/24
- [PATCH 02/16] Acceptance Tests: improve check-acceptance description, Cleber Rosa, 2021/09/24
- [PATCH 04/16] Acceptance Tests: keep track and disable tests with known issues, Cleber Rosa, 2021/09/24