|
From: | Víctor Colombo |
Subject: | Re: [PATCH] target/ppc: Remove support for the PowerPC 602 CPU |
Date: | Fri, 28 Jan 2022 11:13:01 -0300 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 |
On 28/01/2022 10:12, Cédric Le Goater wrote:
The 602 was derived from the PowerPC 603, for the gaming market it seems. It was hardly used and no firmware supporting the CPU could be found. Drop support. Signed-off-by: Cédric Le Goater <clg@kaod.org>
Hello Cédric! I am having problems building QEMU with this patch applied. Tried on both master and legoater/ppc-7.0. I think you forgot one reference to PPC_602_SPEC on cpu.h: #define PPC_TCG_INSNS (PPC_INSNS_BASE | PPC_POWER | PPC_POWER2 \ | PPC_POWER_RTC | PPC_POWER_BR | PPC_64B \ | PPC_64BX | PPC_64H | PPC_WAIT | PPC_MFTB \ - | PPC_602_SPEC | PPC_ISEL | PPC_POPCNTB \ + | PPC_ISEL | PPC_POPCNTB \ | PPC_STRING | PPC_FLOAT | PPC_FLOAT_EXT \ | PPC_FLOAT_FSQRT | PPC_FLOAT_FRES \ | PPC_FLOAT_FRSQRTE | PPC_FLOAT_FRSQRTES \ Could you take a look at it please? Thanks! -- Víctor
[Prev in Thread] | Current Thread | [Next in Thread] |