[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 01/14] hw/ppc/spapr.c: use g_autofree in spapr_dt_chosen()
From: |
David Gibson |
Subject: |
Re: [PATCH 01/14] hw/ppc/spapr.c: use g_autofree in spapr_dt_chosen() |
Date: |
Tue, 1 Mar 2022 11:58:39 +1100 |
On Mon, Feb 28, 2022 at 02:49:51PM -0300, Daniel Henrique Barboza wrote:
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Reviewed-by: David Gibson <david@gibson.dropbear.id.au>
> ---
> hw/ppc/spapr.c | 7 ++-----
> 1 file changed, 2 insertions(+), 5 deletions(-)
>
> diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
> index f0b75b22bb..c74543ace3 100644
> --- a/hw/ppc/spapr.c
> +++ b/hw/ppc/spapr.c
> @@ -1018,9 +1018,9 @@ static void spapr_dt_chosen(SpaprMachineState *spapr,
> void *fdt, bool reset)
>
> if (reset) {
> const char *boot_device = spapr->boot_device;
> - char *stdout_path = spapr_vio_stdout_path(spapr->vio_bus);
> + g_autofree char *stdout_path = spapr_vio_stdout_path(spapr->vio_bus);
> size_t cb = 0;
> - char *bootlist = get_boot_devices_list(&cb);
> + g_autofree char *bootlist = get_boot_devices_list(&cb);
>
> if (machine->kernel_cmdline && machine->kernel_cmdline[0]) {
> _FDT(fdt_setprop_string(fdt, chosen, "bootargs",
> @@ -1087,9 +1087,6 @@ static void spapr_dt_chosen(SpaprMachineState *spapr,
> void *fdt, bool reset)
> }
>
> spapr_dt_ov5_platform_support(spapr, fdt, chosen);
> -
> - g_free(stdout_path);
> - g_free(bootlist);
> }
>
> _FDT(spapr_dt_ovec(fdt, chosen, spapr->ov5_cas,
> "ibm,architecture-vec-5"));
--
David Gibson | I'll have my music baroque, and my code
david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_
| _way_ _around_!
http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature
- [PATCH 00/14] simple cleanups in spapr files, Daniel Henrique Barboza, 2022/02/28
- [PATCH 01/14] hw/ppc/spapr.c: use g_autofree in spapr_dt_chosen(), Daniel Henrique Barboza, 2022/02/28
- Re: [PATCH 01/14] hw/ppc/spapr.c: use g_autofree in spapr_dt_chosen(),
David Gibson <=
- [PATCH 02/14] hw/ppc/spapr.c: fail early if no firmware found in machine_init(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 03/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_cap_set_string(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 04/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_cap_get_string(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 05/14] hw/ppc/spapr_caps.c: use g_autofree in spapr_caps_add_properties(), Daniel Henrique Barboza, 2022/02/28
- [PATCH 06/14] hw/ppc/spapr_drc.c: use g_auto in spapr_dt_drc(), Daniel Henrique Barboza, 2022/02/28