[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/3] 9pfs: Use g_new() & friends where that makes obvious sen
From: |
Alex Bennée |
Subject: |
Re: [PATCH 2/3] 9pfs: Use g_new() & friends where that makes obvious sense |
Date: |
Mon, 14 Mar 2022 19:23:04 +0000 |
User-agent: |
mu4e 1.7.10; emacs 28.0.92 |
Markus Armbruster <armbru@redhat.com> writes:
> g_new(T, n) is neater than g_malloc(sizeof(T) * n). It's also safer,
> for two reasons. One, it catches multiplication overflowing size_t.
> Two, it returns T * rather than void *, which lets the compiler catch
> more type errors.
>
> This commit only touches allocations with size arguments of the form
> sizeof(T).
>
> Patch created mechanically with:
>
> $ spatch --in-place --sp-file scripts/coccinelle/use-g_new-etc.cocci \
> --macro-file scripts/cocci-macro-file.h FILES...
>
> Except this uncovers a typing error:
>
> ../hw/9pfs/9p.c:855:13: warning: incompatible pointer types assigning to
> 'QpfEntry *' from 'QppEntry *' [-Wincompatible-pointer-types]
> val = g_new0(QppEntry, 1);
> ^ ~~~~~~~~~~~~~~~~~~~
> 1 warning generated.
>
> Harmless, because QppEntry is larger than QpfEntry. Fix to allocate a
> QpfEntry instead.
>
> Cc: Greg Kurz <groug@kaod.org>
> Cc: Christian Schoenebeck <qemu_oss@crudebyte.com>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
Reviewed-by: Alex Bennée <alex.bennee@linaro.org>
--
Alex Bennée
- Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense, (continued)
Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense, Eric Blake, 2022/03/15
Re: [PATCH 3/3] Use g_new() & friends where that makes obvious sense, Dr. David Alan Gilbert, 2022/03/15
[PATCH 2/3] 9pfs: Use g_new() & friends where that makes obvious sense, Markus Armbruster, 2022/03/14
[PATCH 1/3] scripts/coccinelle: New use-g_new-etc.cocci, Markus Armbruster, 2022/03/14
Re: [PATCH 0/3] Use g_new() & friends where that makes obvious, Philippe Mathieu-Daudé, 2022/03/14