[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH for-7.1 9/9] hw/ppc/spapr_drc.c: remove spapr_drc_index()
From: |
Daniel Henrique Barboza |
Subject: |
[PATCH for-7.1 9/9] hw/ppc/spapr_drc.c: remove spapr_drc_index() |
Date: |
Fri, 18 Mar 2022 14:33:20 -0300 |
The only remaining caller of this function is the initialization of
drc->index in spapr_dr_connector_new().
Open code the body of the function inside spapr_dr_connector_new() and
remove spapr_drc_index().
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
hw/ppc/spapr_drc.c | 23 ++++++++++-------------
include/hw/ppc/spapr_drc.h | 1 -
2 files changed, 10 insertions(+), 14 deletions(-)
diff --git a/hw/ppc/spapr_drc.c b/hw/ppc/spapr_drc.c
index 11a49620c8..8c8654121c 100644
--- a/hw/ppc/spapr_drc.c
+++ b/hw/ppc/spapr_drc.c
@@ -39,18 +39,6 @@ SpaprDrcType spapr_drc_type(SpaprDrc *drc)
return 1 << drck->typeshift;
}
-uint32_t spapr_drc_index(SpaprDrc *drc)
-{
- SpaprDrcClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);
-
- /* no set format for a drc index: it only needs to be globally
- * unique. this is how we encode the DRC type on bare-metal
- * however, so might as well do that here
- */
- return (drck->typeshift << DRC_INDEX_TYPE_SHIFT)
- | (drc->id & DRC_INDEX_ID_MASK);
-}
-
static void spapr_drc_release(SpaprDrc *drc)
{
SpaprDrcClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);
@@ -546,11 +534,20 @@ SpaprDrc *spapr_dr_connector_new(Object *owner, const
char *type,
uint32_t id)
{
SpaprDrc *drc = SPAPR_DR_CONNECTOR(object_new(type));
+ SpaprDrcClass *drck = SPAPR_DR_CONNECTOR_GET_CLASS(drc);
g_autofree char *prop_name = NULL;
drc->id = id;
drc->owner = owner;
- drc->index = spapr_drc_index(drc);
+
+ /*
+ * No set format for a drc index: it only needs to be globally
+ * unique. This is how we encode the DRC type on bare-metal
+ * however, so might as well do that here.
+ */
+ drc->index = (drck->typeshift << DRC_INDEX_TYPE_SHIFT) |
+ (drc->id & DRC_INDEX_ID_MASK);
+
prop_name = g_strdup_printf("dr-connector[%"PRIu32"]", drc->index);
object_property_add_child(owner, prop_name, OBJECT(drc));
object_unref(OBJECT(drc));
diff --git a/include/hw/ppc/spapr_drc.h b/include/hw/ppc/spapr_drc.h
index 93825e47a6..33cdb3cc20 100644
--- a/include/hw/ppc/spapr_drc.h
+++ b/include/hw/ppc/spapr_drc.h
@@ -228,7 +228,6 @@ static inline bool spapr_drc_hotplugged(DeviceState *dev)
/* Returns true if an unplug request completed */
bool spapr_drc_reset(SpaprDrc *drc);
-uint32_t spapr_drc_index(SpaprDrc *drc);
SpaprDrcType spapr_drc_type(SpaprDrc *drc);
SpaprDrc *spapr_dr_connector_new(Object *owner, const char *type,
--
2.35.1
- [PATCH for-7.1 0/9] spapr: add drc->index, remove spapr_drc_index(), Daniel Henrique Barboza, 2022/03/18
- [PATCH for-7.1 1/9] hw/ppc/spapr_drc.c: add drc->index, Daniel Henrique Barboza, 2022/03/18
- [PATCH for-7.1 2/9] hw/ppc/spapr_drc.c: redefine 'index' SpaprDRC property, Daniel Henrique Barboza, 2022/03/18
- [PATCH for-7.1 3/9] hw/ppc/spapr_drc.c: use drc->index in trace functions, Daniel Henrique Barboza, 2022/03/18
- [PATCH for-7.1 5/9] hw/ppc/spapr.c: use drc->index, Daniel Henrique Barboza, 2022/03/18
- [PATCH for-7.1 4/9] hw/ppc/spapr_drc.c: use drc->index, Daniel Henrique Barboza, 2022/03/18
- [PATCH for-7.1 6/9] hw/ppc/spapr_events.c: use drc->index, Daniel Henrique Barboza, 2022/03/18
- [PATCH for-7.1 9/9] hw/ppc/spapr_drc.c: remove spapr_drc_index(),
Daniel Henrique Barboza <=
- [PATCH for-7.1 7/9] hw/ppc/spapr_nvdimm.c: use drc->index, Daniel Henrique Barboza, 2022/03/18
- [PATCH for-7.1 8/9] hw/ppc/spapr_pci.c: use drc->index, Daniel Henrique Barboza, 2022/03/18
- Re: [PATCH for-7.1 0/9] spapr: add drc->index, remove spapr_drc_index(), David Gibson, 2022/03/20