|
From: | Paolo Bonzini |
Subject: | Re: [PATCH 06/18] ui/vnc: Require audiodev= |
Date: | Wed, 27 Apr 2022 11:32:41 +0200 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0 |
On 4/25/22 10:21, Martin Kletzander wrote:
@@ -4188,12 +4188,15 @@ void vnc_display_open(const char *id, Error **errp) vd->ledstate = 0;audiodev = qemu_opt_get(opts, "audiodev");- if (audiodev) { - vd->audio_state = audio_state_by_name(audiodev); - if (!vd->audio_state) { - error_setg(errp, "Audiodev '%s' not found", audiodev); - goto fail; - } + if (!audiodev) { + error_setg(errp, "Audiodev parameter for vnc required"); + goto fail; + } +
Wouldn't this break "-vnc :0"? You can just ignore the audio commands if vd->audio_state is NULL.
Paolo
[Prev in Thread] | Current Thread | [Next in Thread] |