[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 15/29] target/ppc: remove unused interrupts from p8_deliver_in
From: |
Matheus Ferst |
Subject: |
[PATCH v3 15/29] target/ppc: remove unused interrupts from p8_deliver_interrupt |
Date: |
Tue, 11 Oct 2022 17:48:15 -0300 |
Remove the following unused interrupts from the POWER8 interrupt
processing method:
- PPC_INTERRUPT_RESET: only raised for 6xx, 7xx, 970 and POWER5p;
- Debug Interrupt: removed in Power ISA v2.07;
- Hypervisor Virtualization: introduced in Power ISA v3.0;
- Critical Input, Watchdog Timer, and Fixed Interval Timer: only defined
for embedded CPUs;
- Critical Doorbell: processor does not implement the
"Embedded.Processor Control" category;
- Programmable Interval Timer: 40x-only;
- PPC_INTERRUPT_THERM: only raised for 970 and POWER5p;
Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
---
v3:
- Keep Hypervisor and Privileged Doorbell interrupts, the category for
processor control instruction became "Embedded.Processor Control" or
"Server" on Power ISA v2.07, so the interrupts are still necessary.
---
target/ppc/excp_helper.c | 36 ------------------------------------
1 file changed, 36 deletions(-)
diff --git a/target/ppc/excp_helper.c b/target/ppc/excp_helper.c
index 1d1b26b8d8..662daad796 100644
--- a/target/ppc/excp_helper.c
+++ b/target/ppc/excp_helper.c
@@ -1984,29 +1984,16 @@ static void p8_deliver_interrupt(CPUPPCState *env, int
interrupt)
CPUState *cs = env_cpu(env);
switch (interrupt) {
- case PPC_INTERRUPT_RESET: /* External reset */
- env->pending_interrupts &= ~PPC_INTERRUPT_RESET;
- powerpc_excp(cpu, POWERPC_EXCP_RESET);
- break;
case PPC_INTERRUPT_MCK: /* Machine check exception */
env->pending_interrupts &= ~PPC_INTERRUPT_MCK;
powerpc_excp(cpu, POWERPC_EXCP_MCHECK);
break;
-#if 0 /* TODO */
- case PPC_INTERRUPT_DEBUG: /* External debug exception */
- env->pending_interrupts &= ~PPC_INTERRUPT_DEBUG;
- powerpc_excp(cpu, POWERPC_EXCP_DEBUG);
- break;
-#endif
case PPC_INTERRUPT_HDECR: /* Hypervisor decrementer exception */
/* HDEC clears on delivery */
env->pending_interrupts &= ~PPC_INTERRUPT_HDECR;
powerpc_excp(cpu, POWERPC_EXCP_HDECR);
break;
- case PPC_INTERRUPT_HVIRT: /* Hypervisor virtualization interrupt */
- powerpc_excp(cpu, POWERPC_EXCP_HVIRT);
- break;
case PPC_INTERRUPT_EXT:
if (books_vhyp_promotes_external_to_hvirt(cpu)) {
@@ -2015,26 +2002,7 @@ static void p8_deliver_interrupt(CPUPPCState *env, int
interrupt)
powerpc_excp(cpu, POWERPC_EXCP_EXTERNAL);
}
break;
- case PPC_INTERRUPT_CEXT: /* External critical interrupt */
- powerpc_excp(cpu, POWERPC_EXCP_CRITICAL);
- break;
- case PPC_INTERRUPT_WDT: /* Watchdog timer on embedded PowerPC */
- env->pending_interrupts &= ~PPC_INTERRUPT_WDT;
- powerpc_excp(cpu, POWERPC_EXCP_WDT);
- break;
- case PPC_INTERRUPT_CDOORBELL:
- env->pending_interrupts &= ~PPC_INTERRUPT_CDOORBELL;
- powerpc_excp(cpu, POWERPC_EXCP_DOORCI);
- break;
- case PPC_INTERRUPT_FIT: /* Fixed interval timer on embedded PowerPC */
- env->pending_interrupts &= ~PPC_INTERRUPT_FIT;
- powerpc_excp(cpu, POWERPC_EXCP_FIT);
- break;
- case PPC_INTERRUPT_PIT: /* Programmable interval timer on embedded PowerPC
*/
- env->pending_interrupts &= ~PPC_INTERRUPT_PIT;
- powerpc_excp(cpu, POWERPC_EXCP_PIT);
- break;
case PPC_INTERRUPT_DECR: /* Decrementer exception */
if (ppc_decr_clear_on_delivery(env)) {
env->pending_interrupts &= ~PPC_INTERRUPT_DECR;
@@ -2057,10 +2025,6 @@ static void p8_deliver_interrupt(CPUPPCState *env, int
interrupt)
env->pending_interrupts &= ~PPC_INTERRUPT_PERFM;
powerpc_excp(cpu, POWERPC_EXCP_PERFM);
break;
- case PPC_INTERRUPT_THERM: /* Thermal interrupt */
- env->pending_interrupts &= ~PPC_INTERRUPT_THERM;
- powerpc_excp(cpu, POWERPC_EXCP_THERM);
- break;
case PPC_INTERRUPT_EBB: /* EBB exception */
env->pending_interrupts &= ~PPC_INTERRUPT_EBB;
if (env->spr[SPR_BESCR] & BESCR_PMEO) {
--
2.25.1
- [PATCH v3 10/29] target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER9, (continued)
- [PATCH v3 10/29] target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER9, Matheus Ferst, 2022/10/11
- [PATCH v3 11/29] target/ppc: add power-saving interrupt masking logic to p9_next_unmasked_interrupt, Matheus Ferst, 2022/10/11
- [PATCH v3 13/29] target/ppc: remove unused interrupts from p8_next_unmasked_interrupt, Matheus Ferst, 2022/10/11
- [PATCH v3 12/29] target/ppc: create an interrupt masking method for POWER8, Matheus Ferst, 2022/10/11
- [PATCH v3 14/29] target/ppc: create an interrupt deliver method for POWER8, Matheus Ferst, 2022/10/11
- [PATCH v3 15/29] target/ppc: remove unused interrupts from p8_deliver_interrupt,
Matheus Ferst <=
- [PATCH v3 17/29] target/ppc: move power-saving interrupt masking out of cpu_has_work_POWER8, Matheus Ferst, 2022/10/11
- [PATCH v3 16/29] target/ppc: remove generic architecture checks from p8_deliver_interrupt, Matheus Ferst, 2022/10/11
- [PATCH v3 18/29] target/ppc: add power-saving interrupt masking logic to p8_next_unmasked_interrupt, Matheus Ferst, 2022/10/11
- [PATCH v3 19/29] target/ppc: create an interrupt masking method for POWER7, Matheus Ferst, 2022/10/11
- [PATCH v3 20/29] target/ppc: remove unused interrupts from p7_next_unmasked_interrupt, Matheus Ferst, 2022/10/11