[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 27/38] target/ppc: Fix xvcmp* clearing FI bit
From: |
Daniel Henrique Barboza |
Subject: |
[PULL 27/38] target/ppc: Fix xvcmp* clearing FI bit |
Date: |
Mon, 17 Oct 2022 16:19:58 -0300 |
From: Víctor Colombo <victor.colombo@eldorado.org.br>
Vector instructions in general are not supposed to change the FI bit.
However, xvcmp* instructions are calling gen_helper_float_check_status,
which is leading to a cleared FI flag where it should be kept
unchanged.
As helper_float_check_status only affects inexact, overflow and
underflow, and the xvcmp* instructions don't change these flags, this
issue can be fixed by removing the call to helper_float_check_status.
By doing this, the FI bit in FPSCR will be preserved as expected.
Fixes: 00084a25adf ("target/ppc: introduce separate VSX_CMP macro for xvcmp*
instructions")
Signed-off-by: Víctor Colombo <victor.colombo@eldorado.org.br>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20221005121551.27957-1-victor.colombo@eldorado.org.br>
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
---
target/ppc/translate/vsx-impl.c.inc | 1 -
1 file changed, 1 deletion(-)
diff --git a/target/ppc/translate/vsx-impl.c.inc
b/target/ppc/translate/vsx-impl.c.inc
index 7acdbceec4..e6e5c45ffd 100644
--- a/target/ppc/translate/vsx-impl.c.inc
+++ b/target/ppc/translate/vsx-impl.c.inc
@@ -810,7 +810,6 @@ static void gen_##name(DisasContext *ctx)
\
gen_helper_##name(ignored, cpu_env, xt, xa, xb); \
tcg_temp_free_i32(ignored); \
} \
- gen_helper_float_check_status(cpu_env); \
tcg_temp_free_ptr(xt); \
tcg_temp_free_ptr(xa); \
tcg_temp_free_ptr(xb); \
--
2.37.3
- [PULL 11/38] ppc440_sdram: Split off map/unmap of sdram banks for later reuse, (continued)
- [PULL 11/38] ppc440_sdram: Split off map/unmap of sdram banks for later reuse, Daniel Henrique Barboza, 2022/10/17
- [PULL 13/38] ppc440_sdram: Get rid of the init RAM hack, Daniel Henrique Barboza, 2022/10/17
- [PULL 15/38] ppc4xx_sdram: Rename functions to prevent name clashes, Daniel Henrique Barboza, 2022/10/17
- [PULL 09/38] ppc4xx_sdram: QOM'ify, Daniel Henrique Barboza, 2022/10/17
- [PULL 14/38] ppc440_sdram: Rename local variable for readability, Daniel Henrique Barboza, 2022/10/17
- [PULL 18/38] ppc440_uc.c: Move some macros to ppc4xx.h, Daniel Henrique Barboza, 2022/10/17
- [PULL 16/38] ppc440_sdram: Move RAM size check to ppc440_sdram_init, Daniel Henrique Barboza, 2022/10/17
- [PULL 17/38] ppc440_sdram: QOM'ify, Daniel Henrique Barboza, 2022/10/17
- [PULL 26/38] hw/ppc/e500: Remove if statement which is now always true, Daniel Henrique Barboza, 2022/10/17
- [PULL 22/38] docs/system/ppc/ppce500: Add heading for networking chapter, Daniel Henrique Barboza, 2022/10/17
- [PULL 27/38] target/ppc: Fix xvcmp* clearing FI bit,
Daniel Henrique Barboza <=
- [PULL 19/38] ppc440_uc.c: Remove unneeded parenthesis, Daniel Henrique Barboza, 2022/10/17
- [PULL 20/38] hw/ppc/meson: Allow e500 boards to be enabled separately, Daniel Henrique Barboza, 2022/10/17
- [PULL 21/38] hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx, Daniel Henrique Barboza, 2022/10/17
- [PULL 29/38] qmp/hmp, device_tree.c: introduce dumpdtb, Daniel Henrique Barboza, 2022/10/17
- [PULL 31/38] hw/ppc: set machine->fdt in bamboo_load_device_tree(), Daniel Henrique Barboza, 2022/10/17
- [PULL 23/38] hw/ppc/e500: Reduce usage of sysbus API, Daniel Henrique Barboza, 2022/10/17
- [PULL 25/38] hw/ppc/mpc8544ds: Add platform bus, Daniel Henrique Barboza, 2022/10/17
- [PULL 24/38] hw/ppc/mpc8544ds: Rename wrongly named method, Daniel Henrique Barboza, 2022/10/17
- [PULL 33/38] hw/ppc: set machine->fdt in xilinx_load_device_tree(), Daniel Henrique Barboza, 2022/10/17
- [PULL 35/38] hw/ppc: set machine->fdt in pnv_reset(), Daniel Henrique Barboza, 2022/10/17