[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6] Trivial PPC cleanups
From: |
Bernhard Beschow |
Subject: |
Re: [PATCH 0/6] Trivial PPC cleanups |
Date: |
Wed, 21 Dec 2022 17:04:57 +0000 |
Am 21. Dezember 2022 10:27:51 UTC schrieb Daniel Henrique Barboza
<danielhb413@gmail.com>:
>
>
>On 12/20/22 19:53, Bernhard Beschow wrote:
>>
>>
>> Am 20. Dezember 2022 22:40:25 UTC schrieb Bernhard Beschow
>> <shentey@gmail.com>:
>>>
>>>
>>> Am 16. Dezember 2022 17:50:41 UTC schrieb Daniel Henrique Barboza
>>> <danielhb413@gmail.com>:
>>>> Queued in gitlab.com/danielhb/qemu/tree/ppc-next. Thanks,
>>>
>>> Thanks Daniel!
>>>
>>> Is there a way we could accomodate for Zoltan's comment still? It's just
>>> cosmetics, so should be pretty simple.
>>
>> Yeah, you sent a pull request already! Thanks!
>>
>> I''ll address Zoltan's comment in a future series since I'm working on e500
>> anyway.
>
>I'll have to respin the pull request due to a clang error. I'll take the
>opportunity to amend patch 4 with mister Balaton's suggestion.
Yay!
Best regards,
Bernhard
>
>
>Daniel
>
>>
>> Best regards,
>> Bernhard
>>
>>>
>>> Best regards,
>>> Bernhard
>>>>
>>>>
>>>> Daniel
>>>>
>>>> On 12/16/22 11:57, Bernhard Beschow wrote:
>>>>> These are some patches which helped me when getting a u-boot image to run
>>>>> on ppce500 machine.
>>>>>
>>>>> Testing done:
>>>>> - `make check`
>>>>> - `make check-avocado`
>>>>>
>>>>> Bernhard Beschow (6):
>>>>> target/ppc/mmu_common: Log which effective address had no TLB entry
>>>>> found
>>>>> target/ppc/mmu_common: Fix table layout of "info tlb" HMP command
>>>>> hw/ppc/virtex_ml507: Prefer local over global variable
>>>>> hw/ppc/e500: Prefer local variable over qdev_get_machine()
>>>>> hw/ppc/e500: Resolve variable shadowing
>>>>> hw/ppc/e500: Move comment to more appropriate place
>>>>>
>>>>> hw/ppc/e500.c | 10 ++++------
>>>>> hw/ppc/virtex_ml507.c | 2 +-
>>>>> target/ppc/mmu_common.c | 5 +++--
>>>>> 3 files changed, 8 insertions(+), 9 deletions(-)
>>>>>
- [PATCH 3/6] hw/ppc/virtex_ml507: Prefer local over global variable, (continued)