[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[qemu-s390x] [PULL 05/11] s390x/pci: Send correct event on hotplug
From: |
Cornelia Huck |
Subject: |
[qemu-s390x] [PULL 05/11] s390x/pci: Send correct event on hotplug |
Date: |
Fri, 18 Jan 2019 13:19:19 +0100 |
From: David Hildenbrand <address@hidden>
Comit 2c28c490571f ("s390x/pci: let pci devices start in configured mode")
changed the initial state of zPCI devices from ZPCI_FS_STANDBY to
ZPCI_FS_DISABLED (a.k.a. configured). However we still only send a
HP_EVENT_RESERVED_TO_STANDBY event to the guest, indicating a wrong
state.
Let's send a HP_EVENT_TO_CONFIGURED event instead, to match the actual
state the device is in.
This fixes hotplugged devices having to be enabled explicitly in the
guest e.g. via echo 1 > /sys/bus/pci/slots/00000000/power.
On real HW, a PCI device always pops up in the STANDBY state. In QEMU,
we decided to let it show up directly in the configured state (as
configuring it is otherwise just an extra burden for the admin). We can
safely bypass the STANDBY state when hotplugging PCI devices to a guest.
Fixes: 2c28c490571f ("s390x/pci: let pci devices start in configured mode")
Reported-by: Cornelia Huck <address@hidden>
Signed-off-by: David Hildenbrand <address@hidden>
Message-Id: <address@hidden>
Tested-by: Cornelia Huck <address@hidden>
Reviewed-by: Pierre Morel <address@hidden>
Reviewed-by: Collin Walling <address@hidden>
Signed-off-by: Cornelia Huck <address@hidden>
---
hw/s390x/s390-pci-bus.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/s390x/s390-pci-bus.c b/hw/s390x/s390-pci-bus.c
index a94700a78c..1579989213 100644
--- a/hw/s390x/s390-pci-bus.c
+++ b/hw/s390x/s390-pci-bus.c
@@ -899,7 +899,7 @@ static void s390_pcihost_plug(HotplugHandler *hotplug_dev,
DeviceState *dev,
}
if (dev->hotplugged) {
- s390_pci_generate_plug_event(HP_EVENT_RESERVED_TO_STANDBY,
+ s390_pci_generate_plug_event(HP_EVENT_TO_CONFIGURED ,
pbdev->fh, pbdev->fid);
}
} else if (object_dynamic_cast(OBJECT(dev), TYPE_S390_PCI_DEVICE)) {
--
2.17.2
- [qemu-s390x] [PULL 00/11] s390x updates, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 01/11] s390: avoid potential null dereference in s390_pcihost_unplug(), Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 03/11] s390x: Return specification exception for unimplemented diag 308 subcodes, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 05/11] s390x/pci: Send correct event on hotplug,
Cornelia Huck <=
- [qemu-s390x] [PULL 04/11] configure: Only build the s390-ccw bios if the compiler supports -march=z900, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 02/11] pc-bios/s390-ccw: Use proper register names for Clang, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 06/11] s390x/pci: Set the iommu region size mpcifc request, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 07/11] s390x/pci: Use hotplug_dev instead of looking up the host bridge, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 08/11] s390x/pci: Move some hotplug checks to the pre_plug handler, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 09/11] s390x/pci: Always delete and free the release_timer, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 11/11] s390x/pci: add common function measurement block, Cornelia Huck, 2019/01/18
- [qemu-s390x] [PULL 10/11] s390x/pci: Ignore the unplug call if we already have a release_timer, Cornelia Huck, 2019/01/18
- Re: [qemu-s390x] [PULL 00/11] s390x updates, Peter Maydell, 2019/01/18