[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [qemu-s390x] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for M
From: |
David Hildenbrand |
Subject: |
Re: [qemu-s390x] [PATCH] target/s390x: define TCG_GUEST_DEFAULT_MO for MTTCG |
Date: |
Fri, 18 Jan 2019 18:35:52 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.1 |
On 18.01.19 18:18, Alex Bennée wrote:
> MTTCG should be enabled by default whenever the memory model allows
> it. s390x was missing its definition of TCG_GUEST_DEFAULT_MO meaning
> the user had to manually specify --accel tcg,thread=multi.
>
> Signed-off-by: Alex Bennée <address@hidden>
> Cc: David Hildenbrand <address@hidden>
> ---
> target/s390x/cpu.h | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/target/s390x/cpu.h b/target/s390x/cpu.h
> index 8c2320e882..47d2c2e9cf 100644
> --- a/target/s390x/cpu.h
> +++ b/target/s390x/cpu.h
> @@ -35,6 +35,10 @@
> #define CPUArchState struct CPUS390XState
>
> #include "exec/cpu-defs.h"
> +
> +/* The z/Architecture has a strong memory model with some store-after-load
> re-ordering */
> +#define TCG_GUEST_DEFAULT_MO (TCG_MO_ALL & ~TCG_MO_ST_LD)
Didn't know this was the way to make it be enabled as default.
As discussed on IRC
Reviewed-by: David Hildenbrand <address@hidden>
Thanks!
> +
> #define TARGET_PAGE_BITS 12
>
> #define TARGET_PHYS_ADDR_SPACE_BITS 64
>
--
Thanks,
David / dhildenb