[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Clean up includes
From: |
Thomas Huth |
Subject: |
Re: [PATCH] Clean up includes |
Date: |
Fri, 13 Nov 2020 10:17:26 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 13/11/2020 07.12, Markus Armbruster wrote:
> Clean up includes so that osdep.h is included first and headers
> which it implies are not included manually.
>
> This commit was created with scripts/clean-includes, with the changes
> to the following files manually reverted:
>
> contrib/libvhost-user/libvhost-user-glib.h
> contrib/libvhost-user/libvhost-user.c
> contrib/libvhost-user/libvhost-user.h
> contrib/plugins/hotblocks.c
> contrib/plugins/hotpages.c
> contrib/plugins/howvec.c
> contrib/plugins/lockstep.c
> linux-user/mips64/cpu_loop.c
> linux-user/mips64/signal.c
> linux-user/sparc64/cpu_loop.c
> linux-user/sparc64/signal.c
> linux-user/x86_64/cpu_loop.c
> linux-user/x86_64/signal.c
> target/s390x/gen-features.c
> tests/fp/platform.h
> tests/migration/s390x/a-b-bios.c
> tests/plugin/bb.c
> tests/plugin/empty.c
> tests/plugin/insn.c
> tests/plugin/mem.c
> tests/test-rcu-simpleq.c
> tests/test-rcu-slist.c
> tests/test-rcu-tailq.c
> tests/uefi-test-tools/UefiTestToolsPkg/BiosTablesTest/BiosTablesTest.c
>
> contrib/plugins/, tests/plugin/, and tests/test-rcu-slist.c appear not
> to include osdep.h intentionally. The remaining reverts are the same
> as in commit bbfff19688d.
>
> Signed-off-by: Markus Armbruster <armbru@redhat.com>
> ---
> No real need to get this into 5.2 at this stage. No real risk either.
Seems to compile fine:
https://gitlab.com/huth/qemu/-/pipelines/215598144
https://cirrus-ci.com/build/6127772462481408
https://travis-ci.com/github/huth/qemu/builds/201194948
Tested-by: Thomas Huth <thuth@redhat.com>
- [PATCH] Clean up includes, Markus Armbruster, 2020/11/13
- Re: [PATCH] Clean up includes, Paolo Bonzini, 2020/11/13
- Re: [PATCH] Clean up includes, Dr. David Alan Gilbert, 2020/11/13
- Re: [PATCH] Clean up includes,
Thomas Huth <=
- Re: [PATCH] Clean up includes, Cornelia Huck, 2020/11/13
- Re: [PATCH] Clean up includes, Michael S. Tsirkin, 2020/11/13
- Re: [PATCH] Clean up includes, Stefan Hajnoczi, 2020/11/17
- Re: [PATCH] Clean up includes, Alexander Bulekov, 2020/11/17