Re: [PATCH] ui: Fix pixel colour channel order for PNG screenshots

[Peter Maydell]

On Tue, 2 May 2023 at 21:36, BALATON Zoltan <balaton@eik.bme.hu> wrote:
>
> On Tue, 2 May 2023, Peter Maydell wrote:
> > When we take a PNG screenshot the ordering of the colour channels in
> > the data is not correct, resulting in the image having weird
> > colouring compared to the actual display.  (Specifically, on a
> > little-endian host the blue and red channels are swapped; on
> > big-endian everything is wrong.)
> >
> > This happens because the pixman idea of the pixel data and the libpng
> > idea differ.  PIXMAN_a9r8g8b8 defines that pixels are 32-bit values,
>
> Typo: should be PIXMAN_a8r8g8b8 not a9

Thanks -- I super-carefully proof-read that to make sure I'd got
the a r g and b in the right order and completely missed the 8 vs 9 :-)

-- PMM