qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] qed: remove unneeded variable assignment


From: Pavel Borzenkov
Subject: [Qemu-trivial] [PATCH] qed: remove unneeded variable assignment
Date: Tue, 18 Oct 2011 21:17:56 +0400

'ret' is unconditionally overwitten by qed_read_l1_table_sync()

Spotted by Clang Analyzer

Signed-off-by: Pavel Borzenkov <address@hidden>
---
 block/qed.c |    1 -
 1 files changed, 0 insertions(+), 1 deletions(-)

diff --git a/block/qed.c b/block/qed.c
index e87dc4d..c3e45af 100644
--- a/block/qed.c
+++ b/block/qed.c
@@ -388,7 +388,6 @@ static int bdrv_qed_open(BlockDriverState *bs, int flags)
     if (ret < 0) {
         return ret;
     }
-    ret = 0; /* ret should always be 0 or -errno */
     qed_header_le_to_cpu(&le_header, &s->header);
 
     if (s->header.magic != QED_MAGIC) {
-- 
1.7.0.4




reply via email to

[Prev in Thread] Current Thread [Next in Thread]