Re: [Qemu-trivial] [PATCH 2/2] linux-user/main.c: Add option to user-mode emulation so that user can specify log file name

[Stefan Hajnoczi]

On Sat, Nov 05, 2011 at 04:18:19PM +0800, Chen Wen-Ren wrote:
>   Add an option so that user can specify the log file name they want.
> 
> Signed-off-by: Chen Wen-Ren <address@hidden>
> ---
>  linux-user/main.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/linux-user/main.c b/linux-user/main.c
> index d1bbc57..c275c0b 100644
> --- a/linux-user/main.c
> +++ b/linux-user/main.c
> @@ -45,6 +45,7 @@ int gdbstub_port;
>  envlist_t *envlist;
>  const char *cpu_model;
>  unsigned long mmap_min_addr;
> +extern const char *logfilename;

linux-user/main.c already uses cpu_set_log_filename(log_file).  It
should not be necessary to make exec.c:logfilename global.

Take a look at how bsd-user/main.c does what you're trying to do.

Please send the patch through the linux-user maintainer, Riku Voipio
<address@hidden>, since this adds a user-visible command-line
option.

Stefan