Re: [Qemu-trivial] [Qemu-devel] [PATCH] darwin-user: Fix format string in debug message

[Andreas Färber]

Am 19.11.2011 20:18, schrieb Stefan Weil:
> This was spotted by cppcheck.
> 
> Signed-off-by: Stefan Weil <address@hidden>
> ---
>  darwin-user/signal.c |    3 +--
>  1 files changed, 1 insertions(+), 2 deletions(-)
> 
> diff --git a/darwin-user/signal.c b/darwin-user/signal.c
> index c530227..317ef92 100644
> --- a/darwin-user/signal.c
> +++ b/darwin-user/signal.c
> @@ -270,8 +270,7 @@ int do_sigaction(int sig, const struct sigaction *act,
>          host_sig = target_to_host_signal(sig);
>          if (host_sig != SIGSEGV && host_sig != SIGBUS) {
>  #if defined(DEBUG_SIGNAL)
> -    fprintf(stderr, "sigaction handler going to call sigaction\n",
> -            act->sa_handler, act->sa_flags, act->sa_mask);
> +            fprintf(stderr, "sigaction handler going to call sigaction\n");
>  #endif
>  
>              sigfillset(&act1.sa_mask);

Is the debug output really useful without the information? Maybe rather
append %p %x %x? What does linux-user do?

Andreas