qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Don't skip stracing for


From: Alexander Graf
Subject: Re: [Qemu-trivial] [PATCH] linux-user/syscall.c: Don't skip stracing for fcntl64 failure case
Date: Tue, 6 Dec 2011 00:34:52 +0100

On 06.12.2011, at 00:11, Peter Maydell wrote:

> In an fcntl64 failure path, we were returning directly rather than
> simply breaking out of the switch statement. This skips the strace
> code for printing the syscall return value, so don't do that.
> 
> Signed-off-by: Peter Maydell <address@hidden>

Acked-by: Alexander Graf <address@hidden>


Alex

> ---
> Alex Graf spotted this one...
> 
> linux-user/syscall.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/linux-user/syscall.c b/linux-user/syscall.c
> index f227097..4846b41 100644
> --- a/linux-user/syscall.c
> +++ b/linux-user/syscall.c
> @@ -7521,8 +7521,10 @@ abi_long do_syscall(void *cpu_env, int num, abi_long 
> arg1,
> #endif
> 
>       cmd = target_to_host_fcntl_cmd(arg2);
> -     if (cmd == -TARGET_EINVAL)
> -             return cmd;
> +        if (cmd == -TARGET_EINVAL) {
> +            ret = cmd;
> +            break;
> +        }
> 
>         switch(arg2) {
>         case TARGET_F_GETLK64:
> -- 
> 1.7.5.4
> 




reply via email to

[Prev in Thread] Current Thread [Next in Thread]