qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] Strip trailing '\n' from error_report()'s fir


From: Stefan Hajnoczi
Subject: Re: [Qemu-trivial] [PATCH] Strip trailing '\n' from error_report()'s first argument (again)
Date: Wed, 21 Dec 2011 11:01:02 +0000
User-agent: Mutt/1.5.21 (2010-09-15)

On Tue, Dec 20, 2011 at 06:13:08PM +0100, Markus Armbruster wrote:
> Commit 6daf194d got rid of them, but Hans and Gerd added some more
> lately.  Tracked down with this Coccinelle semantic patch:
> 
> @r@
>     expression fmt;
>     position p;
> @@
>     error_report(fmt, ...)@p
> @script:python@
>     fmt << r.fmt;
>     p << r.p;
> @@
> if "\\n" in str(fmt):
>     print "%s:%s:%s:%s" % (p[0].file, p[0].line, p[0].column, fmt)
> 
> Signed-off-by: Markus Armbruster <address@hidden>
> ---
>  hw/usb-bus.c |   12 ++++++------
>  usb-redir.c  |    4 ++--
>  2 files changed, 8 insertions(+), 8 deletions(-)

Thanks, applied to the trivial patches tree:
https://github.com/stefanha/qemu/commits/trivial-patches

Stefan



reply via email to

[Prev in Thread] Current Thread [Next in Thread]