qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [PATCH] memory-region: Report if region is read-only


From: Jan Kiszka
Subject: Re: [Qemu-trivial] [PATCH] memory-region: Report if region is read-only on info mtree
Date: Sat, 04 Feb 2012 13:23:46 +0100
User-agent: Mozilla/5.0 (X11; U; Linux i686 (x86_64); de; rv:1.8.1.12) Gecko/20080226 SUSE/2.0.0.12-1.1 Thunderbird/2.0.0.12 Mnenhy/0.7.5.666

On 2012-02-04 13:12, Blue Swirl wrote:
> On Fri, Feb 3, 2012 at 12:02, Jan Kiszka <address@hidden> wrote:
>> Helpful to understand guest configurations of things like the i440FX's
>> PAM.
>>
>> Signed-off-by: Jan Kiszka <address@hidden>
>> ---
>>  memory.c |    6 ++++--
>>  1 files changed, 4 insertions(+), 2 deletions(-)
>>
>> diff --git a/memory.c b/memory.c
>> index ee4c98a..ea4adda 100644
>> --- a/memory.c
>> +++ b/memory.c
>> @@ -1608,23 +1608,25 @@ static void mtree_print_mr(fprintf_function 
>> mon_printf, void *f,
>>             ml->printed = false;
>>             QTAILQ_INSERT_TAIL(alias_print_queue, ml, queue);
>>         }
>> -        mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d): alias 
>> %s @%s "
>> +        mon_printf(f, TARGET_FMT_plx "-" TARGET_FMT_plx " (prio %d, %s): 
>> alias %s @%s "
>>                    TARGET_FMT_plx "-" TARGET_FMT_plx "\n",
>>                    base + mr->addr,
>>                    base + mr->addr
>>                    + (target_phys_addr_t)int128_get64(mr->size) - 1,
>>                    mr->priority,
>> +                   mr->readonly ? "RO" : "RW",
> 
> I think the reserved regions which are unreadable and unwritable
> should be shown as well. Then the output should be a combination of
> 'R', 'W' or neither ('-').

Reserved regions are in the hand of some other device model (so far only
the KVM kernel). That says nothing about their R/W property. If we ever
have a reserved region that is not writable, the owner could still set
the corresponding flag for documentation purposes.

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


reply via email to

[Prev in Thread] Current Thread [Next in Thread]