Re: [Qemu-trivial] [Qemu-devel] [TRIVIAL] sas_ss_flags bug for powerpc

[Alexander Graf]

On 09.02.2012, at 19:43, Andreas Färber wrote:

> Am 09.02.2012 19:30, schrieb Alex Barcelo:
>> Signed-off-by: Alex Barcelo <address@hidden>
> 
> This patch needs a better description than "bug"

Yes. In general I also reject patches with empty description.

> , and you forgot to cc the linux-user maintainer

Yes

> . The patch should describe what it touches
> (linux-user), what it does, what for and make clear why that is correct.

Yes

> Is there a particular test case that's broken without the patch?

Very important. Please provide a test case that breaks for you.

> I can't speak for Stefan, but to me it is totally unclear from looking
> at the patch what sas_ss_flags() does here so this is likely not really
> a trivial one.

It is definitely not trivial. I think I have a rough understanding of what the 
code does and I agree with the patch in general. But I would still like to see 
a ppc binary break in qemu first.


Alex