[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b9
|
From: |
陳韋任 |
|
Subject: |
Re: [Qemu-trivial] [PATCH] Fix dependency issue introduced by commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 |
|
Date: |
Wed, 22 Feb 2012 10:08:07 +0800 |
|
User-agent: |
Mutt/1.5.21 (2010-09-15) |
On Tue, Feb 21, 2012 at 12:27:26PM +0000, Stefan Hajnoczi wrote:
> On Tue, Feb 21, 2012 at 10:12 AM, 陳韋任 <address@hidden> wrote:
> > Commit 7b93fadf3a38d1ed65ea5536a52efc2772c6e3b8 adds basic version of
> > bridge
> > helper, but introduces dependency issue at the same time. While building
> > target
> > xxx-linux-user, qemu-bridge-helper.c needs config-host.h which is not
> > generated
> > at the moment. Building recurse-all target first fixes the problem.
>
> The build system should not rely on ordering side-effects. Instead,
> please explicitly declare the dependency for the helper or see if the
> dependency can be eliminated if it is inappropriate.
O.K., since the dependency cannot be eliminated, I'll explicitly declare the
dependency for the helper.
Regards,
chenwj
--
Wei-Ren Chen (陳韋任)
Computer Systems Lab, Institute of Information Science,
Academia Sinica, Taiwan (R.O.C.)
Tel:886-2-2788-3799 #1667
Homepage: http://people.cs.nctu.edu.tw/~chenwj