qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [Qemu-trivial] [Qemu-devel] [PATCH] Remove type field in ModuleEntry


From: Andreas Färber
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] Remove type field in ModuleEntry as it's not used.
Date: Wed, 07 Mar 2012 17:19:20 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.2) Gecko/20120215 Thunderbird/10.0.2

Am 07.03.2012 16:36, schrieb Chen Yufei:
> Signed-off-by: Chen Yufei <address@hidden>

There's separate init_type_list[]s per type and the type field is not
even initialized, so:

Acked-by: Andreas Färber <address@hidden>

Thanks,
Andreas

> ---
>  module.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
> 
> diff --git a/module.c b/module.c
> index 106a969..c3a6da7 100644
> --- a/module.c
> +++ b/module.c
> @@ -19,7 +19,6 @@
>  
>  typedef struct ModuleEntry
>  {
> -    module_init_type type;
>      void (*init)(void);
>      QTAILQ_ENTRY(ModuleEntry) node;
>  } ModuleEntry;

-- 
SUSE LINUX Products GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany
GF: Jeff Hawn, Jennifer Guild, Felix Imendörffer; HRB 16746 AG Nürnberg



reply via email to

[Prev in Thread] Current Thread [Next in Thread]