qemu-trivial
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[Qemu-trivial] [PATCH] block: Don't forget to d elete temporary file


From: riegamaths
Subject: [Qemu-trivial] [PATCH] block: Don't forget to d elete temporary file
Date: Wed, 5 Sep 2012 21:26:22 +0800

From: Dunrong Huang <address@hidden>

The caller would not delete temporary file after failed get_tmp_filename().

Signed-off-by: Dunrong Huang <address@hidden>
---
 block.c | 6 +++++-
 1 个文件被修改,插入 5 行(+),删除 1 行(-)

diff --git a/block.c b/block.c
index 074987e..2bc9f75 100644
--- a/block.c
+++ b/block.c
@@ -433,7 +433,11 @@ int get_tmp_filename(char *filename, int size)
         return -EOVERFLOW;
     }
     fd = mkstemp(filename);
-    if (fd < 0 || close(fd)) {
+    if (fd < 0) {
+        return -errno;
+    }
+    if (close(fd) != 0) {
+        unlink(filename);
         return -errno;
     }
     return 0;
-- 
1.7.12




reply via email to

[Prev in Thread] Current Thread [Next in Thread]